summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRemi NGUYEN VAN <reminv@google.com>2020-05-12 10:59:15 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-05-12 10:59:15 +0000
commit41650bbc32270b62110a22587fc4bc9527401219 (patch)
treebac388b844346cbda6243316203afac7b49c58b4
parentbd967a001d76b8736ebc008228fa5b0c9cc6e758 (diff)
parent5c5a6898473e8b446b7e9b8c0e2f85cf69c480ee (diff)
Merge "Finish mocking in finally clause" into rvc-dev am: 5c5a689847
Change-Id: Idd768e7aa4c21501757dbe422d353489710f5e94
-rw-r--r--tests/unit/src/android/net/networkstack/ModuleNetworkStackClientTest.kt18
1 files changed, 10 insertions, 8 deletions
diff --git a/tests/unit/src/android/net/networkstack/ModuleNetworkStackClientTest.kt b/tests/unit/src/android/net/networkstack/ModuleNetworkStackClientTest.kt
index 31b4ffd..d8864e6 100644
--- a/tests/unit/src/android/net/networkstack/ModuleNetworkStackClientTest.kt
+++ b/tests/unit/src/android/net/networkstack/ModuleNetworkStackClientTest.kt
@@ -95,15 +95,17 @@ class ModuleNetworkStackClientTest {
// Force NetworkStack.getService() to return null: this cannot be done with
// setServiceForTest, as passing null just restores default behavior.
val session = mockitoSession().spyStatic(NetworkStack::class.java).startMocking()
- doReturn(null).`when` { NetworkStack.getService() }
- ModuleNetworkStackClient.getInstance(mContext).makeIpClient(TEST_IFNAME, mIpClientCb)
-
- Thread.sleep(TEST_TIMEOUT_MS)
- verify(mConnector, never()).makeIpClient(any(), any())
- NetworkStack.setServiceForTest(mConnectorBinder)
+ try {
+ doReturn(null).`when` { NetworkStack.getService() }
+ ModuleNetworkStackClient.getInstance(mContext).makeIpClient(TEST_IFNAME, mIpClientCb)
- // Restore behavior of NetworkStack to return what was set in setServiceForTest
- session.finishMocking()
+ Thread.sleep(TEST_TIMEOUT_MS)
+ verify(mConnector, never()).makeIpClient(any(), any())
+ NetworkStack.setServiceForTest(mConnectorBinder)
+ } finally {
+ // Restore behavior of NetworkStack to return what was set in setServiceForTest
+ session.finishMocking()
+ }
// Use a longer timeout as polling can cause larger delays
verify(mConnector, timeout(TEST_TIMEOUT_MS * 4)).makeIpClient(TEST_IFNAME, mIpClientCb)