summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLorenzo Colitti <lorenzo@google.com>2020-05-11 08:16:56 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-05-11 08:16:56 +0000
commitbd967a001d76b8736ebc008228fa5b0c9cc6e758 (patch)
tree55d672a1001fb877a85c2ea1e07980c773c986d4
parent449c3af7f103fb7d56bf1a53c0053c3613bc6084 (diff)
parenta90dec38387ad3b6e05b63e0a82bbf7b9ff1d4d4 (diff)
Test that IFA_F_STABLE_PRIVACY appears in LinkAddresses. am: a90dec3838
Change-Id: Ia217f0866968cb99097248684abd74657d63ecc0
-rw-r--r--tests/integration/src/android/net/ip/IpClientIntegrationTest.java9
1 files changed, 6 insertions, 3 deletions
diff --git a/tests/integration/src/android/net/ip/IpClientIntegrationTest.java b/tests/integration/src/android/net/ip/IpClientIntegrationTest.java
index d883433..5625dd2 100644
--- a/tests/integration/src/android/net/ip/IpClientIntegrationTest.java
+++ b/tests/integration/src/android/net/ip/IpClientIntegrationTest.java
@@ -188,6 +188,9 @@ public class IpClientIntegrationTest {
private static final String TEST_GROUPHINT = "some grouphint";
private static final int TEST_LEASE_DURATION_S = 3_600; // 1 hour
+ // TODO: move to NetlinkConstants, NetworkStackConstants, or OsConstants.
+ private static final int IFA_F_STABLE_PRIVACY = 0x800;
+
@Rule
public final DevSdkIgnoreRule mIgnoreRule = new DevSdkIgnoreRule();
@@ -1385,9 +1388,9 @@ public class IpClientIntegrationTest {
}
private boolean isStablePrivacyAddress(LinkAddress addr) {
- // TODO: this is incorrect. Fix netd to report IFA_F_STABLE_PRIVACY on R onwards, and then
- // move away from getting addresses from netd altogether.
- return addr.isGlobalPreferred();
+ // TODO: move away from getting address updates from netd and make this work on Q as well.
+ final int flag = ShimUtils.isAtLeastR() ? IFA_F_STABLE_PRIVACY : 0;
+ return addr.isGlobalPreferred() && hasFlag(addr, flag);
}
private LinkProperties doIpv6OnlyProvisioning(InOrder inOrder, ByteBuffer ra) throws Exception {