diff options
author | Remi NGUYEN VAN <reminv@google.com> | 2019-11-06 13:15:04 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2019-11-06 13:15:04 +0000 |
commit | 362b8c73dde5ffe16a320ba30485c91254bbee28 (patch) | |
tree | a7c42be3e153487bdb92d8f9a653883a477f8252 | |
parent | ee26afe80d3db10afaf693d6b384f25abea70c55 (diff) | |
parent | 5ad0944d24e8dabc7fa56c3325e9200669889641 (diff) |
Merge "Revert "Fix sll_protocol in DhcpClient packet socket""
-rw-r--r-- | Android.bp | 2 | ||||
-rw-r--r-- | apishim/30/com/android/networkstack/apishim/SocketUtilsShimImpl.java | 3 | ||||
-rw-r--r-- | src/android/net/dhcp/DhcpClient.java | 4 |
3 files changed, 4 insertions, 5 deletions
@@ -59,7 +59,7 @@ filegroup { srcs: [ "apishim/common/**/*.java", "apishim/29/**/*.java", - "apishim/30/**/*.java", + "apishim/current/**/*.java", ":net-module-utils-srcs", ], } diff --git a/apishim/30/com/android/networkstack/apishim/SocketUtilsShimImpl.java b/apishim/30/com/android/networkstack/apishim/SocketUtilsShimImpl.java index 748878a..9516e7c 100644 --- a/apishim/30/com/android/networkstack/apishim/SocketUtilsShimImpl.java +++ b/apishim/30/com/android/networkstack/apishim/SocketUtilsShimImpl.java @@ -44,6 +44,7 @@ public class SocketUtilsShimImpl @Override public SocketAddress makePacketSocketAddress( int protocol, int ifIndex, @NonNull byte[] hwAddr) { - return SocketUtils.makePacketSocketAddress(protocol, ifIndex, hwAddr); + // TODO: use new API (which takes protocol, ifIndex, hwAddr) once implemented + return SocketUtils.makePacketSocketAddress(ifIndex, hwAddr); } } diff --git a/src/android/net/dhcp/DhcpClient.java b/src/android/net/dhcp/DhcpClient.java index 889bfce..0d56d63 100644 --- a/src/android/net/dhcp/DhcpClient.java +++ b/src/android/net/dhcp/DhcpClient.java @@ -82,7 +82,6 @@ import com.android.internal.util.StateMachine; import com.android.internal.util.TrafficStatsConstants; import com.android.internal.util.WakeupMessage; import com.android.networkstack.R; -import com.android.networkstack.apishim.SocketUtilsShimImpl; import java.io.FileDescriptor; import java.io.IOException; @@ -390,8 +389,7 @@ public class DhcpClient extends StateMachine { } mHwAddr = mIface.macAddr.toByteArray(); - mInterfaceBroadcastAddr = SocketUtilsShimImpl.newInstance().makePacketSocketAddress( - ETH_P_IP, mIface.index, DhcpPacket.ETHER_BROADCAST); + mInterfaceBroadcastAddr = makePacketSocketAddress(mIface.index, DhcpPacket.ETHER_BROADCAST); return true; } |