summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRemi NGUYEN VAN <reminv@google.com>2019-11-06 13:11:49 +0000
committerRemi NGUYEN VAN <reminv@google.com>2019-11-06 13:11:49 +0000
commit5ad0944d24e8dabc7fa56c3325e9200669889641 (patch)
tree0b0dfe2fa5df46011318592e8433daea840ed78c
parent0c5e74000546a6c148e79985ee5fbf53dc454453 (diff)
Revert "Fix sll_protocol in DhcpClient packet socket"
This reverts commit 0c5e74000546a6c148e79985ee5fbf53dc454453. Reason for revert: Broke build in qt-qpr1-dev-plus-aosp Change-Id: I2e5738e776881f8c4f3cf459398a250560a43559
-rw-r--r--Android.bp2
-rw-r--r--apishim/30/com/android/networkstack/apishim/SocketUtilsShimImpl.java3
-rw-r--r--src/android/net/dhcp/DhcpClient.java4
3 files changed, 4 insertions, 5 deletions
diff --git a/Android.bp b/Android.bp
index 35eaf6c..f17f1b1 100644
--- a/Android.bp
+++ b/Android.bp
@@ -59,7 +59,7 @@ filegroup {
srcs: [
"apishim/common/**/*.java",
"apishim/29/**/*.java",
- "apishim/30/**/*.java",
+ "apishim/current/**/*.java",
":net-module-utils-srcs",
],
}
diff --git a/apishim/30/com/android/networkstack/apishim/SocketUtilsShimImpl.java b/apishim/30/com/android/networkstack/apishim/SocketUtilsShimImpl.java
index 748878a..9516e7c 100644
--- a/apishim/30/com/android/networkstack/apishim/SocketUtilsShimImpl.java
+++ b/apishim/30/com/android/networkstack/apishim/SocketUtilsShimImpl.java
@@ -44,6 +44,7 @@ public class SocketUtilsShimImpl
@Override
public SocketAddress makePacketSocketAddress(
int protocol, int ifIndex, @NonNull byte[] hwAddr) {
- return SocketUtils.makePacketSocketAddress(protocol, ifIndex, hwAddr);
+ // TODO: use new API (which takes protocol, ifIndex, hwAddr) once implemented
+ return SocketUtils.makePacketSocketAddress(ifIndex, hwAddr);
}
}
diff --git a/src/android/net/dhcp/DhcpClient.java b/src/android/net/dhcp/DhcpClient.java
index 889bfce..0d56d63 100644
--- a/src/android/net/dhcp/DhcpClient.java
+++ b/src/android/net/dhcp/DhcpClient.java
@@ -82,7 +82,6 @@ import com.android.internal.util.StateMachine;
import com.android.internal.util.TrafficStatsConstants;
import com.android.internal.util.WakeupMessage;
import com.android.networkstack.R;
-import com.android.networkstack.apishim.SocketUtilsShimImpl;
import java.io.FileDescriptor;
import java.io.IOException;
@@ -390,8 +389,7 @@ public class DhcpClient extends StateMachine {
}
mHwAddr = mIface.macAddr.toByteArray();
- mInterfaceBroadcastAddr = SocketUtilsShimImpl.newInstance().makePacketSocketAddress(
- ETH_P_IP, mIface.index, DhcpPacket.ETHER_BROADCAST);
+ mInterfaceBroadcastAddr = makePacketSocketAddress(mIface.index, DhcpPacket.ETHER_BROADCAST);
return true;
}