summaryrefslogtreecommitdiff
path: root/libs/hwui/pipeline/skia/ReorderBarrierDrawables.cpp
AgeCommit message (Collapse)Author
2021-02-08Remove two macrosJohn Reck
This is colliding with ag/13519705 and causing build issues. So replace the macros with constexpr's which are better Bug: 179047472 Test: make Change-Id: Icf7c38077ef608ec97e737d47d3d6c25246190bf
2019-06-24Fix potential off-by-oneFedor Kudasov
Being consistent with the notion of mEndChildIndex, it should be -1 by default. Otherwise it assumes the display list has a single element. This is consistent with EndReorderBarrierDrawable constructor that would set mEndChildIndex to -1 if display list is empty. Bug: 117921091 Test: all tests should pass Change-Id: I64b84c789ad8126ac8f0b8c2ebfc128635e5b30d
2019-06-19Split lighting out of SkiaPipelineFedor Kudasov
ReorderBarierDrawables includes SkiaPipeline just for the sake of lighting, however SkiaPipeline brings much more unnecessary dependencies. Splitting lighting our of SkiaPipeline should make dependency resolution simpler. Bug: 117921091 Test: all tests should pass Change-Id: I6adf7c43555cfa3ff7090a1197fc11160d3a85ec
2018-12-03Remove ; from closing namespaces in libs/hwuiChris Blume
When closing a namespace a } is sufficient. It doesn't need to be }; like closing a class or enum. Within frameworks/base/libs/hwui there is a mix between } and }; when closing a namespace. There are even mixes between a .h and the corresponding .cpp files. In a separate CL I was asked to not close with };. That was a good comment. I adopted the style from nearby code. This CL cleans up the nearby code. Test: I made sure the code still built as expected. Change-Id: Ieb314a4f48d6e33752463f3be4361fdc9be97482
2018-06-19Restore matrix transform for out-of-order render nodesStan Iliev
Restore matrix for render nodes, which are drawn out of order. Test: DrawChildBug-debug.apk draws correctly, new test ag/4355529 Bug: 80173852 Change-Id: I3f789a7cf0ee5816da84255199b265643f95af1c
2018-04-19Remove unused SkRRectsGaussianEdgeMaskFilter #includeRobert Phillips
SkRRectsGaussianEdgeMaskFilter is going away in Skia (https://skia-review.googlesource.com/c/skia/+/121960 (rm SkRRectsGaussianEdgeMaskFilter)) but this usage needs to be cleaned up first Test: does it compile? Change-Id: I489123a32958ada2d27425d78b3abb2db2290ce8
2018-03-13update call-sites to use SkMaskFilter::MakeBlurMike Reed
Blur is now part of the core, so SkBlurMaskFilter.h is deprecated Test: make Change-Id: I06dd34972f34151e3c7f1e9d384ab2bd39890a56
2018-01-31Add API to set tonal shadow colorJohn Reck
Bug: 68211332 Test: HwAccelerationTests's coloredshadow demo & CTS test in topic Change-Id: I09f5d1067b3200564a9d47219f70985edf3a2527
2017-11-13Create colored shadows demoJohn Reck
Test: HwAccelerationTest demo Bug: 68211332 Change-Id: Ia53a6ac2854570d0495b355bbebee1dcec2f47ba
2017-11-03Format the world (or just HWUI)John Reck
Test: No code changes, just ran through clang-format Change-Id: Id23aa4ec7eebc0446fe3a30260f33e7fd455bb8c
2017-08-30Avoid performing the pathOp for clipped shadows if possible.Derek Sollenberger
Bug: 64487466 Test: SystemUiJankTests#testRecentAppsFling Change-Id: I2ca96bd6adba299cd31e12f005b2529c559740d2
2017-07-18Fix incorrect assertsStan Iliev
Fix a few Skia asserts, which prevent HWUI from compiling and running when SkDebug is defined. Test: Built and ran Android on device. Change-Id: Ie7f16016ba105e1d376c266c5b030e4bc04629d9
2017-05-31Remove unneeded Skia include in ReorderBarrierDrawables.cppFlorin Malita
SkGaussianEdgeShader.h is a private Skia header, and not used at all in ReorderBarrierDrawables.cpp. Test: refactoring CL. Existing unit tests still pass. Change-Id: I01c6b2a9ce53617ce338a7fbd45554d2d2604c9e Signed-off-by: Florin Malita <fmalita@google.com> (cherry picked from commit 4bb94d19c6771cf886f1e94dbc2ca3da9c9f8dce)
2017-05-15Update to new SkShadowUtils interfaceJim Van Verth
Test: Ran shadowgrid2 with change and saw no visible differences. Change-Id: I5f47b02b67cc9de5a887d1af2eff7a181a0e46f8
2017-04-13Add uncached and perspective shadows to Skia rendererJim Van Verth
Test: manual - looked at FrameworkShadow app Bug: 37300468 Change-Id: I72d820479141db2d83363747d9f76abbaca70d98
2017-04-04Fix pop-up shadow drawn in the wrong place with Skia pipelineStan Iliev
Fix a bug in DrawShadow matrix calculation. Recorded matrix does not need to be applied, because parent display lists have already replayed matrix transformations. Test: added a new HWUI unit test that is passing only after this fix Bug: 33103723 Change-Id: I7a47dbe879df6b9e5920a47c0e1168d9902a3e70
2017-02-06Use new Skia DrawShadow APIStan Iliev
Use new Skia DrawShadow API to draw shadows and remove unused code from HWUI. Test: Built and ran shadow macrobench tests. Change-Id: Ief86b03b7348367f8bae8c212d64d5a545eebaeb
2016-12-01Fix a crash in skia pipeline, when empty reorder block is firstStan Iliev
Fix a crash in skia pipeline, which happens if an empty reorder barrier is inserted at index 0 in a SkiaDisplayList. Add a unit test that repro the bug (unit test is crashing wihtout the fix and passing with the fix). Test: built and ran skia pipeline with angler-eng and run HWUI unit tests. Change-Id: I4aded15021c70cc0ae8daa83bbe8ed0e10a41eef
2016-11-09Cleanup asserts and remove usage of deprecated data structure.Derek Sollenberger
Test: compile only Change-Id: I9e9f1a3fb37db043d76a98a9568679e7e531e283
2016-11-03Merge "Implement Skia pipelines for OpenGL and Vulkan."TreeHugger Robot
2016-11-03Implement Skia pipelines for OpenGL and Vulkan.Stan Iliev
Implement Skia pipelines for OpenGL and Vulkan: base SkiaPipeline, SkiaOpenGLPipeline and SkiaVulkanPipeline. Write unit tests for SkiaPipeline. Test: Built and run manually on angler-eng. Change-Id: Ie02583426cb3547541ad9bf91700602a6163ff58
2016-11-02Adding changes required by the master-skia merge.Derek Sollenberger
Test: compile only Change-Id: I39637a20da439edbf2831952df9bfa12da78e9b9
2016-10-31Implement SkiaRecordingCanvas, RenderNodeDrawable and other drawables.Stan Iliev
Implement SkiaRecordingCanvas, RenderNodeDrawable, GLFunctorDrawable, LayerDrawable, StartReorderBarrierDrawable, EndReorderBarrierDrawable. Move AnimatedRoundRect and AnimatedCircle in a separate file. All Skia pipeline files are moved in hwui/pipeline/skia folder. Add unit tests for RenderNodeDrawable, StartReorderBarrierDrawable, EndReorderBarrierDrawable and SkiaRecordingCanvas. Test: I tested manually on 6P devices and did run the unit tests. Change-Id: If2a347bd1fc4689953822294ce5bf98c7f3f57c7
generated by cgit v1.2.3 (git 2.25.1) at 2025-10-03 13:51:13 +0000