diff options
| author | Stan Iliev <stani@google.com> | 2017-04-04 15:23:54 -0400 |
|---|---|---|
| committer | Stan Iliev <stani@google.com> | 2017-04-04 16:24:55 -0400 |
| commit | d7410f7829ff591ca81ad93c9c9b1632ea80d1bc (patch) | |
| tree | df96deb44315806245c9d53a850a8919d3dcc19e /libs/hwui/pipeline/skia/ReorderBarrierDrawables.cpp | |
| parent | 5879d28f4df66e0222476226ce7a8e8b62314d04 (diff) | |
Fix pop-up shadow drawn in the wrong place with Skia pipeline
Fix a bug in DrawShadow matrix calculation. Recorded matrix does
not need to be applied, because parent display lists have already
replayed matrix transformations.
Test: added a new HWUI unit test that is passing only after this fix
Bug: 33103723
Change-Id: I7a47dbe879df6b9e5920a47c0e1168d9902a3e70
Diffstat (limited to 'libs/hwui/pipeline/skia/ReorderBarrierDrawables.cpp')
| -rw-r--r-- | libs/hwui/pipeline/skia/ReorderBarrierDrawables.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libs/hwui/pipeline/skia/ReorderBarrierDrawables.cpp b/libs/hwui/pipeline/skia/ReorderBarrierDrawables.cpp index 2ead5c5897d2..d26eb59a039a 100644 --- a/libs/hwui/pipeline/skia/ReorderBarrierDrawables.cpp +++ b/libs/hwui/pipeline/skia/ReorderBarrierDrawables.cpp @@ -162,7 +162,7 @@ void EndReorderBarrierDrawable::drawShadow(SkCanvas* canvas, RenderNodeDrawable* SkAutoCanvasRestore acr(canvas, true); SkMatrix shadowMatrix; - mat4 hwuiMatrix(caster->getRecordedMatrix()); + mat4 hwuiMatrix; // TODO we don't pass the optional boolean to treat it as a 4x4 matrix caster->getRenderNode()->applyViewPropertyTransforms(hwuiMatrix); hwuiMatrix.copyTo(shadowMatrix); |