summaryrefslogtreecommitdiff
path: root/libs/hwui/renderthread/RenderProxy.cpp
diff options
context:
space:
mode:
authorJohn Reck <jreck@google.com>2021-06-25 17:33:33 +0000
committerJohn Reck <jreck@google.com>2021-06-25 18:59:47 +0000
commitf0b6921e894922b28143b281d006dee1285258f6 (patch)
tree9ff55800034dbc29831d639c5f3c651692ce97fb /libs/hwui/renderthread/RenderProxy.cpp
parentda3559683482a61d93b06bed6f46349f6f01dc63 (diff)
Revert "Delete RenderProxy off of the cleaner thread"
This reverts commit da3559683482a61d93b06bed6f46349f6f01dc63. Bug: b/192050906 If too many RenderProxies are destroyed too quickly, we can end up jamming up the CommonPool preventing RenderThread from making progress if it's waiting on CommonPool tasks. Change-Id: I8c324bc60891440d9b7be67961f8d5f881dc0f03
Diffstat (limited to 'libs/hwui/renderthread/RenderProxy.cpp')
-rw-r--r--libs/hwui/renderthread/RenderProxy.cpp12
1 files changed, 0 insertions, 12 deletions
diff --git a/libs/hwui/renderthread/RenderProxy.cpp b/libs/hwui/renderthread/RenderProxy.cpp
index 8291fa7e4bab..c47050c31e9a 100644
--- a/libs/hwui/renderthread/RenderProxy.cpp
+++ b/libs/hwui/renderthread/RenderProxy.cpp
@@ -26,7 +26,6 @@
#include "renderthread/CanvasContext.h"
#include "renderthread/RenderTask.h"
#include "renderthread/RenderThread.h"
-#include "thread/CommonPool.h"
#include "utils/Macros.h"
#include "utils/TimeUtils.h"
@@ -43,17 +42,6 @@ RenderProxy::RenderProxy(bool translucent, RenderNode* rootRenderNode,
mDrawFrameTask.setContext(&mRenderThread, mContext, rootRenderNode);
}
-void RenderProxy::asyncDelete(RenderProxy* proxy) {
- if (!proxy) return;
-
- if (proxy->mContext) {
- // Use the common pool because ~RenderProxy blocks on calling into RenderThread
- CommonPool::post([proxy]() { delete proxy; });
- } else {
- delete proxy;
- }
-}
-
RenderProxy::~RenderProxy() {
destroyContext();
}