summaryrefslogtreecommitdiff
path: root/update_boot_flags_action_unittest.cc
AgeCommit message (Collapse)Author
2020-11-03update_engine: Create cros vs. aosp boundary clearAmin Hassani
Its time to make the boundary between Chrome OS and Android code more clear. This CL moves all CrOS only code to "chromeos" directory and the same for Android (in "android" directory). This way we would easily know which code is uses in which project and can keep the code cleaner and more maintainable. One big remaining problem is download_action* files. It seems like DownloadAction class does a lot of things that chrome OS needs and it depends on a lot of Chrome OS stuff, but Android is also using thie Action in a way that circumvent the Chrome OS stuff. For example Android checks for SystemState to be nullptr to not do things. This is really fragile and needs to change. Probably Android Team has to implement their own DownloadAction of some sort and not re use the Chrome OS one in a very fragile way. Removed a few android files that have not been used anywhere. Changed some clang-format and lint issues in order to pass preupload. BUG=b:171829801 TEST=cros_workon_make --board reef --test update_engine Change-Id: I3fff1d4a100a065a5c1484a845241b5521614d9f Reviewed-on: https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2508965 Tested-by: Amin Hassani <ahassani@chromium.org> Auto-Submit: Amin Hassani <ahassani@chromium.org> Reviewed-by: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by: Tianjie Xu <xunchang@google.com> Reviewed-by: Kelvin Zhang <zhangkelvin@google.com> Commit-Queue: Amin Hassani <ahassani@chromium.org>
2018-07-25update_engine: Pospone setgoodkernel after update checkAmin Hassani
Currently, if an update is forced, we first run setgoodkernel and then continue with the update check. However, this delays the update check screen in the OOBE. This patch adds a new Action, UpdateBootFlagsAction which is configured to run AFTER an update check and response. However, now if the update check failed due for example the response was invalid, then setgoodkernel will not happen. But we already have a mechanism in SystemState where setgoodkernel is always called (currently) 45 seconds after the boot. So there would no worries. BUG=chromium:807976 TEST=unittests TEST=powerwashed the device, and the check for update passed faster on OOBE. Change-Id: I5845d7a4c1393aec568b6279dfbb7d3dfa31cdd8 Reviewed-on: https://chromium-review.googlesource.com/1011244 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Sen Jiang <senj@chromium.org>