diff options
Diffstat (limited to 'update_manager/update_manager_unittest.cc')
| -rw-r--r-- | update_manager/update_manager_unittest.cc | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/update_manager/update_manager_unittest.cc b/update_manager/update_manager_unittest.cc index 39427b39..95fd3e00 100644 --- a/update_manager/update_manager_unittest.cc +++ b/update_manager/update_manager_unittest.cc @@ -128,14 +128,16 @@ TEST_F(UmUpdateManagerTest, PolicyRequestCallsDefaultOnError) { EXPECT_TRUE(result.updates_enabled); } -TEST_F(UmUpdateManagerTest, PolicyRequestDoesntBlock) { +// This test only applies to debug builds where DCHECK is enabled. +#if DCHECK_IS_ON +TEST_F(UmUpdateManagerTest, PolicyRequestDoesntBlockDeathTest) { + // The update manager should die (DCHECK) if a policy called synchronously + // returns a kAskMeAgainLater value. UpdateCheckParams result; umut_->set_policy(new LazyPolicy()); - - EvalStatus status = umut_->PolicyRequest( - &Policy::UpdateCheckAllowed, &result); - EXPECT_EQ(EvalStatus::kAskMeAgainLater, status); + EXPECT_DEATH(umut_->PolicyRequest(&Policy::UpdateCheckAllowed, &result), ""); } +#endif // DCHECK_IS_ON TEST_F(UmUpdateManagerTest, AsyncPolicyRequestDelaysEvaluation) { // To avoid differences in code execution order between an AsyncPolicyRequest |