diff options
author | Mike Frysinger <vapier@chromium.org> | 2014-05-14 16:28:23 -0400 |
---|---|---|
committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2014-05-15 23:52:53 +0000 |
commit | bcee2ca34ebcd3b0abc7bc611370d323e55fa62c (patch) | |
tree | b5a991b4af0fcb74173dc50a1026e84e4693d7eb /utils.h | |
parent | a03a6910f2bad3bcdcc3eb5a8140bb607854f2fe (diff) |
use IGNORE_EINTR w/close
HANDLE_EINTR is both not safe and not useful on Linux systems.
Switch to IGNORE_EINTR like Chromium has done everywhere.
See http://crbug.com/269623 for details.
BUG=chromium:373154
TEST=`cbuildbot {arm,amd64,x86}-generic-full` passes
Change-Id: Ia2ee7db803366f1305919c4c40c2709e62faae20
Reviewed-on: https://chromium-review.googlesource.com/199823
Reviewed-by: Alex Deymo <deymo@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Diffstat (limited to 'utils.h')
-rw-r--r-- | utils.h | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -480,7 +480,7 @@ class ScopedEintrSafeFdCloser { explicit ScopedEintrSafeFdCloser(int* fd) : fd_(fd), should_close_(true) {} ~ScopedEintrSafeFdCloser() { if (should_close_ && fd_ && (*fd_ >= 0)) { - if (!HANDLE_EINTR(close(*fd_))) + if (!IGNORE_EINTR(close(*fd_))) *fd_ = -1; } } |