diff options
| author | Jae Hoon Kim <kimjae@chromium.org> | 2019-07-11 14:35:38 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2019-07-23 18:32:54 +0000 |
| commit | ed3fcc05a9c47c26bec6f524d33855aa5813e00d (patch) | |
| tree | f126b41804f9b8033ca1939b2c1e0bda1cf83fec /update_status_utils_unittest.cc | |
| parent | 7b428f507892dc8f80895ae43e8fe12b75be2ad8 (diff) | |
update_engine: Clear lingering install indication
When an install for DLC is initiated, the member variable |is_install_|
is set to true, however the issue arises from that fact that it is never
reverted to be false. This can cause periodic updates to still have the
lingering |is_install_| as true from a previous install. The state must
be correctly cleaned up/cleared.
|ProcessingDone()| will be called at the end of an install/update. This
also depends on the fact that |is_install_| will not be changed by the
time |OnUpdateScheduled()| is scheduled periodically or forced up until
|ProcessingDone()| for an install or update is finished.
The new approach is to have |ProcessingDone()| dispatch to two different
methods (|ProcessingDoneInstall()| and |ProcessingDoneUpdate()|) based
on what the action finished on (an install or update indicated by
|is_install_|). Then those dispatched actions will be performed, then
the |is_install_| can be reset.
BUG=chromium:982929
TEST=FEATURES="test" P2_TEST_FILTER="*UpdateAttempterTest.*-*RunAsRoot*" emerge-$BOARD update_engine
TEST=FEATURES="test" emerge-$BOARD update_engine
Change-Id: I1fb9387dd416ed0815964cfcb22a6559ab81fa80
Diffstat (limited to 'update_status_utils_unittest.cc')
0 files changed, 0 insertions, 0 deletions