diff options
| author | Amin Hassani <ahassani@chromium.org> | 2019-06-17 18:09:10 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2019-06-27 20:04:38 -0700 |
| commit | ecb60d31efccf3ac4b02c8750e79b03fd5c10ff9 (patch) | |
| tree | 1b2f25eee9a6d361521bcb6a11263d187b1320f9 /scripts/update_payload/format_utils_unittest.py | |
| parent | edb65502fe728573c508e6ef04d90180b00e7ac8 (diff) | |
update_engine: Reset forced update flag before sending Omaha ping
Lack of resetting the forced update flag causes
InteractiveUpdatePolicyImpl to always return true for (non-)interactive
updates and this can cause the update check to fall into an infinite
loop because the policy will never reach to
NextUpdateCheckTimePolicyImpl:
CheckForUpdate -> ScheduleUpdates -> OnUpdateScheduled -> Update ->
PingOmaha -> ScheduleUpdates
BUG=chromium:960828
TEST=unitest
TEST=updated device using this flow:
- update_engine_client --interactive=false --update
- wait till the state changed to wait_reboot
- update_engine_client --interactive=false --update
and no infinite loop was entered.
Change-Id: Ie8f8308d8af79f56cd71324bcb8679897f6823e7
Reviewed-on: https://chromium-review.googlesource.com/1666252
Tested-by: Amin Hassani <ahassani@chromium.org>
Commit-Ready: Amin Hassani <ahassani@chromium.org>
Legacy-Commit-Queue: Commit Bot <commit-bot@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>
Diffstat (limited to 'scripts/update_payload/format_utils_unittest.py')
0 files changed, 0 insertions, 0 deletions