summaryrefslogtreecommitdiff
path: root/scripts/update_payload/format_utils_unittest.py
diff options
context:
space:
mode:
authorTianjie Xu <xunchang@google.com>2019-12-11 13:53:39 -0800
committerTianjie Xu <xunchang@google.com>2019-12-17 20:43:08 +0000
commit60f3a238b23e0cbaa76b7a0a5d7d99a5d8ff8035 (patch)
tree38d1df48671cb8413cc793a914a4a73c8b085348 /scripts/update_payload/format_utils_unittest.py
parenteec29279a8869100458472b8803804f33c01f9d2 (diff)
During binding, check the status when calling callback functions
In a separate bug, we encounter a selinux denial when the update_engine domain tries to call function from gmscore domain (through the callback). This results in an infinite progress bar in the UI, and adds confusion to testers and users. Even though the callback function is defined as oneway in the aidl, I find it returns status with the error message upon selinux denial: Status(-129, EX_TRANSACTION_FAILED): 'FAILED_TRANSACTION: ' So, we should at least check this status and return false in the bind(). We also need to unbind the callback in such case. So the caller can bind() again later without storing two callbacks in update_engine. Bug: 146073270 Bug: 145340049 Test: check the error message and return value upon selinux denial Change-Id: I7aeb80637704907090974192deaa17ba3eadc822
Diffstat (limited to 'scripts/update_payload/format_utils_unittest.py')
0 files changed, 0 insertions, 0 deletions