summaryrefslogtreecommitdiff
path: root/scripts/update_payload/checker_unittest.py
diff options
context:
space:
mode:
authorSen Jiang <senj@google.com>2017-06-21 17:46:41 -0700
committerchrome-bot <chrome-bot@chromium.org>2017-08-01 13:01:40 -0700
commit73b18b83ebae881cefa6fb2b0563a0b94c17bcde (patch)
treef2ec3bfbce85a62cdea4f83bc6dad7110f7b175c /scripts/update_payload/checker_unittest.py
parent1a53ba073b3899e41cd44c2225c7975c0211752f (diff)
update_engine: Only split operation if it has multiple dst extents.
FragmentOperations() will split operations so that every operation will have only one dst extent, but if the operation already meet this requirement, it should be a no-op and we shouldn't waste time recompressing it. This can save a lot of time if there's huge replace operation that only has one dst extent. As a side effect of not splitting those operations, if they are SOURCE_COPY operations, they will not have src_length and dst_length set anymore, because those were set in SplitSourceCopy() before this change, but these lengths are never actually used in delta performer since the very first implementation of PerformSourceCopyOperation(): https://chromium-review.googlesource.com/c/263747/ So it's safe to remove it from the manifest. We might as well just remove src_length and dst_length in all SOURCE_COPY operations (even for those are splitted) to reduce payload size a little bit. BUG=b:62470452 TEST=generated a payload, all operations are still the same except SOURCE_COPY don't have src_length and dst_length any more Change-Id: I019ca9056479165e76cc25d7a4ba453088398928 (cherry picked from commit 929461ab11769339108658f2022d068446ca90f7) Reviewed-on: https://chromium-review.googlesource.com/594909 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Sen Jiang <senj@chromium.org>
Diffstat (limited to 'scripts/update_payload/checker_unittest.py')
0 files changed, 0 insertions, 0 deletions