diff options
| author | Gilad Arnold <garnold@chromium.org> | 2013-10-04 18:18:45 -0700 |
|---|---|---|
| committer | chrome-internal-fetch <chrome-internal-fetch@google.com> | 2013-10-07 18:31:12 +0000 |
| commit | 6a3a3878daddc2536a2ac9033189274cfc5ef52d (patch) | |
| tree | a969f9169908b5ea4c73c1608238f3d5244575eb /scripts/update_payload/checker.py | |
| parent | cb638915dbc2e0898b0562c98019c077d7fc1e8a (diff) | |
paycheck: fix errors around percentage / formatting of zero sizes
This fixes two problems, both having to do with histogram generation:
* When the total number of elements is zero, paycheck would crash due to
a division by zero; further, even if the crash is fixed (returning,
say, None) the histogram will contain a meaningless value in
parenthesis, which we might as well drop. Both are fixed here.
* When some size (say, bytes) is zero, its formatter
(bytes-to-human-readable) returns None, which shows up as is in the
final report. This should be checked and avoided.
BUG=None
TEST=Crash fixed; None percentage/formatted value omitted.
Change-Id: I8bb5fbc47e1cde9dcbee7f7b96bcb63ef3a0935e
Reviewed-on: https://chromium-review.googlesource.com/172046
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Gilad Arnold <garnold@chromium.org>
Tested-by: Gilad Arnold <garnold@chromium.org>
Diffstat (limited to 'scripts/update_payload/checker.py')
| -rw-r--r-- | scripts/update_payload/checker.py | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/scripts/update_payload/checker.py b/scripts/update_payload/checker.py index 549ffcb8..8a866190 100644 --- a/scripts/update_payload/checker.py +++ b/scripts/update_payload/checker.py @@ -67,7 +67,11 @@ def _AddFormat(format_func, value): Returns: A string 'x (y)' where x = str(value) and y = format_func(value). """ - return '%s (%s)' % (value, format_func(value)) + ret = str(value) + formatted_str = format_func(value) + if formatted_str: + ret += ' (%s)' % formatted_str + return ret def _AddHumanReadableSize(size): |