diff options
| author | Amin Hassani <ahassani@chromium.org> | 2018-12-20 15:35:41 -0800 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-12-23 19:19:26 -0800 |
| commit | 04d41629e027d0c98c91d3702de8b86527ef8224 (patch) | |
| tree | c0013586da2152616a43a06557ba946ed2e1d3b9 /scripts/update_payload/applier.py | |
| parent | 8cb948377fdb159f701ca3fd7513ddcb5ca6f33d (diff) | |
update_engine: Fix a memory access violation
Somewhere down in HttpFetcher there is a pointer to
ChromeBrowserProxyResolver. But the actual object gets deleted before
ActionProcessor is deleted. But ActionProcessor's dtor makes calls that
sometimes eventually gets into the instance of ChromeBrowserproxyresolver and we
get a memory violation.
For now just declare ChromeBrowserProxyResolver before ActionProcessor so it
still exists when the ActionProcessor uses it. Later use shared_ptr to properly
handle it.
BUG=chromium:915922
TEST=cros flash
TEST=Instrumented the dtors and manually stopped the update_engine process to
see the order of dtors are correct.
Change-Id: Ie9fa654103605f04c82521c29614dbcd4fb083e8
Reviewed-on: https://chromium-review.googlesource.com/1388105
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Sen Jiang <senj@chromium.org>
Diffstat (limited to 'scripts/update_payload/applier.py')
0 files changed, 0 insertions, 0 deletions