summaryrefslogtreecommitdiff
path: root/payload_generator/graph_utils.cc
diff options
context:
space:
mode:
authorAlex Deymo <deymo@chromium.org>2014-10-30 01:37:48 -0700
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2014-11-01 03:26:34 +0000
commitf329b933db41d26644a97afef928eb1b319d6d99 (patch)
tree33b47e66d6d2d48f1650d7fecda3b0a23e2994bc /payload_generator/graph_utils.cc
parentebbe7ef75279183ba3cf055158dbbb3b3b605e0e (diff)
update_engine: Fix all the "using" declaration usage.
This patch removes unused "using" declarations, that is, declarations included in a .cc file at a global scope such that "using foo::bar" that later don't use the identifier "bar" at all. This also unifies the usage of these identifiers in the .cc files in favor of using the short name defined by the using declaration. For example, in several cases the .h refer to a type like "std::string" because using declarations are forbidden in header files while the .cc includes "using std::string;" with the purpose of just writting "string" in the .cc file. Very rarely, the full identifier is used when a local name ocludes it, for example, StringVectorToGStrv() and StringVectorToString() in utils.cc named its argument just "vector" need to refer to std::vector with the full name. This patch renames those arguments instead. Finally, it also sorts a few lists of using declarations that weren't in order. BUG=None TEST=FEATURES=test emerge-link update_engine Change-Id: I30f6b9510ecb7e03640f1951c48d5bb106309840 Reviewed-on: https://chromium-review.googlesource.com/226423 Reviewed-by: Alex Vakulenko <avakulenko@chromium.org> Commit-Queue: Alex Deymo <deymo@chromium.org> Tested-by: Alex Deymo <deymo@chromium.org>
Diffstat (limited to 'payload_generator/graph_utils.cc')
-rw-r--r--payload_generator/graph_utils.cc2
1 files changed, 1 insertions, 1 deletions
diff --git a/payload_generator/graph_utils.cc b/payload_generator/graph_utils.cc
index a0ce802d..dd0c8730 100644
--- a/payload_generator/graph_utils.cc
+++ b/payload_generator/graph_utils.cc
@@ -105,7 +105,7 @@ void DropIncomingEdgesTo(Graph* graph, Vertex::Index index) {
}
}
-Extent GetElement(const std::vector<Extent>& collection, size_t index) {
+Extent GetElement(const vector<Extent>& collection, size_t index) {
return collection[index];
}
Extent GetElement(