summaryrefslogtreecommitdiff
path: root/payload_generator/graph_utils.cc
diff options
context:
space:
mode:
authorChris Sosa <sosa@chromium.org>2014-06-02 18:16:24 -0700
committerchrome-internal-fetch <chrome-internal-fetch@google.com>2014-06-05 01:36:34 +0000
commit77f79e876a77796fc248d099b6574f05bd23c954 (patch)
treee2b92a5d3bcdfb401efb96148bcf181605b98a0a /payload_generator/graph_utils.cc
parent5665d0ced6812771559ca7bf938fa48f2b93ae48 (diff)
Only disable update downloads over expensive connections, not all transfers.
Previous to this CL, all network traffic was disabled from the update engine if an update wasn't allowed. Instead, in this CL, we switch to only disable the update application portion (downloading and applying the payload). This is done by moving the detection logic from the mechanism (the network fetcher) to the user of said mechanism i.e. the omaha request/response actions. I have done a little refactoring of the unittests to make this CL easier to test and found 1 bug in the http_fetcher_unittests where we weren't sending either the right URL or handling a server not existing correctly. This CL comes with one caveat: Technically in the previous impl if a download started over wifi then got disconnected / retried and bounced to a different connection type that we couldn't update over, we'd stop the update. This would no longer be true here if the http_fetcher recovered seamlessly. BUG=chromium:379832 TEST=Unittests Change-Id: I6b1a76e4c030d4e384e8ba0b519424a35406aafb Reviewed-on: https://chromium-review.googlesource.com/202435 Tested-by: Chris Sosa <sosa@chromium.org> Reviewed-by: David Zeuthen <zeuthen@chromium.org> Commit-Queue: Chris Sosa <sosa@chromium.org>
Diffstat (limited to 'payload_generator/graph_utils.cc')
0 files changed, 0 insertions, 0 deletions