diff options
| author | Kevin Cernekee <cernekee@google.com> | 2016-03-29 18:03:53 -0700 |
|---|---|---|
| committer | Kevin Cernekee <cernekee@google.com> | 2016-03-30 23:35:07 +0000 |
| commit | 2494e28b88a819618c6325a5b081ef7de28549ee (patch) | |
| tree | cfdf329c8fd97cdfca11bb8edf3f7febd790c6c0 /metrics_utils.cc | |
| parent | d3251ef5abddc1c42fa0910191831454264e3cda (diff) | |
Skip non-critical updates during OOBE update check
If the system has not yet completed OOBE, and Omaha returns a response
with an empty deadline field, avoid initiating a background update
because doing so may violate an enterprise policy that gets pushed
down post-enrollment.
Bug: None
BUG=chromium:587101
TEST=`FEATURES=test emerge-link chromeos-base/update_engine`
TEST=powerwash, install lsb-release file from an old stable build,
repeat OOBE, verify that download is skipped via logs, then verify
that update proceeds after logging into a standard gmail account
Change-Id: I6e6fae02c609b2763abc6e9960bf6d87dd3534e2
Diffstat (limited to 'metrics_utils.cc')
| -rw-r--r-- | metrics_utils.cc | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/metrics_utils.cc b/metrics_utils.cc index 11260fc6..e165e897 100644 --- a/metrics_utils.cc +++ b/metrics_utils.cc @@ -99,7 +99,10 @@ metrics::AttemptResult GetAttemptResult(ErrorCode code) { case ErrorCode::kDownloadInvalidMetadataSignature: case ErrorCode::kOmahaResponseInvalid: case ErrorCode::kOmahaUpdateIgnoredPerPolicy: + // TODO(deymo): The next two items belong in their own category; they + // should not be counted as internal errors. b/27112092 case ErrorCode::kOmahaUpdateDeferredPerPolicy: + case ErrorCode::kNonCriticalUpdateInOOBE: case ErrorCode::kOmahaErrorInHTTPResponse: case ErrorCode::kDownloadMetadataSignatureMissingError: case ErrorCode::kOmahaUpdateDeferredForBackoff: @@ -193,6 +196,7 @@ metrics::DownloadErrorCode GetDownloadErrorCode(ErrorCode code) { case ErrorCode::kOmahaResponseInvalid: case ErrorCode::kOmahaUpdateIgnoredPerPolicy: case ErrorCode::kOmahaUpdateDeferredPerPolicy: + case ErrorCode::kNonCriticalUpdateInOOBE: case ErrorCode::kOmahaErrorInHTTPResponse: case ErrorCode::kDownloadOperationHashMissingError: case ErrorCode::kDownloadMetadataSignatureMissingError: |