diff options
| author | Amin Hassani <ahassani@chromium.org> | 2020-10-27 15:44:33 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-10-29 00:30:43 +0000 |
| commit | 5d56c1eef7fd730a164c44a742ef2cb0afcfca8d (patch) | |
| tree | 572f28ad39889ff2aac8883db17562120517465c /common/utils_unittest.cc | |
| parent | e8153631e85189ab578aa04b556801ee80d6d686 (diff) | |
update_engine: Remove ec_version and fw_version
It seems like these values were set for devices like parrot that have
been AUE'ed long time ago. The server side doesn't use this values and
it doesn't seem we need them anywhere. So its better to not send them
anymore since currently we're just sending empty values for them.
BUG=b:171829801
TEST=FEATURES=test emerge-reef update_engine
Change-Id: I2d2cd5f9d079ce5c87fc8167e30f91d1ffe1c87a
Reviewed-on: https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2504454
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Jae Hoon Kim <kimjae@chromium.org>
Reviewed-by: Tianjie Xu <xunchang@google.com>
Commit-Queue: Amin Hassani <ahassani@chromium.org>
Diffstat (limited to 'common/utils_unittest.cc')
| -rw-r--r-- | common/utils_unittest.cc | 13 |
1 files changed, 0 insertions, 13 deletions
diff --git a/common/utils_unittest.cc b/common/utils_unittest.cc index d73b3da7..bc5c3b05 100644 --- a/common/utils_unittest.cc +++ b/common/utils_unittest.cc @@ -41,19 +41,6 @@ namespace chromeos_update_engine { class UtilsTest : public ::testing::Test {}; -TEST(UtilsTest, CanParseECVersion) { - // Should be able to parse and valid key value line. - EXPECT_EQ("12345", utils::ParseECVersion("fw_version=12345")); - EXPECT_EQ("123456", - utils::ParseECVersion("b=1231a fw_version=123456 a=fasd2")); - EXPECT_EQ("12345", utils::ParseECVersion("fw_version=12345")); - EXPECT_EQ("00VFA616", - utils::ParseECVersion("vendor=\"sam\" fw_version=\"00VFA616\"")); - - // For invalid entries, should return the empty string. - EXPECT_EQ("", utils::ParseECVersion("b=1231a fw_version a=fasd2")); -} - TEST(UtilsTest, WriteFileOpenFailure) { EXPECT_FALSE(utils::WriteFile("/this/doesn't/exist", "hello", 5)); } |