diff options
| author | Amin Hassani <ahassani@chromium.org> | 2020-10-27 15:44:33 -0700 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-10-29 00:30:43 +0000 |
| commit | 5d56c1eef7fd730a164c44a742ef2cb0afcfca8d (patch) | |
| tree | 572f28ad39889ff2aac8883db17562120517465c /common/mock_hardware.h | |
| parent | e8153631e85189ab578aa04b556801ee80d6d686 (diff) | |
update_engine: Remove ec_version and fw_version
It seems like these values were set for devices like parrot that have
been AUE'ed long time ago. The server side doesn't use this values and
it doesn't seem we need them anywhere. So its better to not send them
anymore since currently we're just sending empty values for them.
BUG=b:171829801
TEST=FEATURES=test emerge-reef update_engine
Change-Id: I2d2cd5f9d079ce5c87fc8167e30f91d1ffe1c87a
Reviewed-on: https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2504454
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Jae Hoon Kim <kimjae@chromium.org>
Reviewed-by: Tianjie Xu <xunchang@google.com>
Commit-Queue: Amin Hassani <ahassani@chromium.org>
Diffstat (limited to 'common/mock_hardware.h')
| -rw-r--r-- | common/mock_hardware.h | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/common/mock_hardware.h b/common/mock_hardware.h index 84c0c5ba..071906b5 100644 --- a/common/mock_hardware.h +++ b/common/mock_hardware.h @@ -45,11 +45,6 @@ class MockHardware : public HardwareInterface { ON_CALL(*this, GetHardwareClass()) .WillByDefault( testing::Invoke(&fake_, &FakeHardware::GetHardwareClass)); - ON_CALL(*this, GetFirmwareVersion()) - .WillByDefault( - testing::Invoke(&fake_, &FakeHardware::GetFirmwareVersion)); - ON_CALL(*this, GetECVersion()) - .WillByDefault(testing::Invoke(&fake_, &FakeHardware::GetECVersion)); ON_CALL(*this, GetMinKernelKeyVersion()) .WillByDefault( testing::Invoke(&fake_, &FakeHardware::GetMinKernelKeyVersion)); @@ -90,8 +85,6 @@ class MockHardware : public HardwareInterface { MOCK_CONST_METHOD0(IsOOBEEnabled, bool()); MOCK_CONST_METHOD1(IsOOBEComplete, bool(base::Time* out_time_of_oobe)); MOCK_CONST_METHOD0(GetHardwareClass, std::string()); - MOCK_CONST_METHOD0(GetFirmwareVersion, std::string()); - MOCK_CONST_METHOD0(GetECVersion, std::string()); MOCK_CONST_METHOD0(GetMinKernelKeyVersion, int()); MOCK_CONST_METHOD0(GetMinFirmwareKeyVersion, int()); MOCK_CONST_METHOD0(GetMaxFirmwareKeyRollforward, int()); |