diff options
| author | Amin Hassani <ahassani@chromium.org> | 2018-05-16 13:34:00 -0700 |
|---|---|---|
| committer | chrome-bot <chrome-bot@chromium.org> | 2018-05-23 12:50:53 -0700 |
| commit | 80f4d4cefb5270960d17cd347d71594e97c7a954 (patch) | |
| tree | 115e34a098a80a083e975b0854e6e7615653879d /common/hardware_interface.h | |
| parent | 761be2cfd245cd8378bf8efc65b39a31cc065809 (diff) | |
update_engine: Report VPD write failure to UMA
Currently we see many first actives to come from non-FSI images. But we have not
been able to figure out why. This CL, reports a new error
kFirstActiveOmahaPingSentPersistenceError when writing the first active omaha
flag into VPD fails. This allows us to see if that is the actual cause of the
problem.
CL:1062659 adds the enum value on the Chrome side.
BUG=chromium:833980
TEST=unittests
TEST=precq
Change-Id: I65e233c5f895489ba905494fb20d7b00d0c4af10
Reviewed-on: https://chromium-review.googlesource.com/1062662
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>
Diffstat (limited to 'common/hardware_interface.h')
| -rw-r--r-- | common/hardware_interface.h | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/common/hardware_interface.h b/common/hardware_interface.h index 4d7c162a..239e7c81 100644 --- a/common/hardware_interface.h +++ b/common/hardware_interface.h @@ -110,9 +110,9 @@ class HardwareInterface { // |SetFirstActiveOmahaPingSent()|. virtual bool GetFirstActiveOmahaPingSent() const = 0; - // Persist the fact that first active ping was sent to omaha. It bails out if - // it fails. - virtual void SetFirstActiveOmahaPingSent() = 0; + // Persist the fact that first active ping was sent to omaha and returns false + // if failed to persist it. + virtual bool SetFirstActiveOmahaPingSent() = 0; }; } // namespace chromeos_update_engine |