diff options
| author | Amin Hassani <ahassani@chromium.org> | 2020-11-13 18:40:35 -0800 |
|---|---|---|
| committer | Commit Bot <commit-bot@chromium.org> | 2020-11-18 06:03:00 +0000 |
| commit | 9ed2cee8de1d853d098009b10d3dec84944b3be4 (patch) | |
| tree | 18d0adbdcec6110d31c9fd6a72c3aaaed8b339e9 /common/dynamic_partition_control_interface.h | |
| parent | 6178903b970af7ff24c224f7d51eb7c7c14bc52f (diff) | |
update_engine: Don't keep pointer to SystemState available objects
These objects are available thorugh SystemState. No need to keep pointer
to them in various classes (OmahaRequestBuilderXml in this case). This
makes testing/debugging easier because there will be one central
location for getting pointers to these values.
BUG=b:171829801
TEST=cros_workon_make --board reef --test update_engine
Change-Id: I02a36afdc7dcb00e02b1a61263141745afc7fb26
Reviewed-on: https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/2543814
Tested-by: Amin Hassani <ahassani@chromium.org>
Reviewed-by: Jae Hoon Kim <kimjae@chromium.org>
Commit-Queue: Amin Hassani <ahassani@chromium.org>
Diffstat (limited to 'common/dynamic_partition_control_interface.h')
| -rw-r--r-- | common/dynamic_partition_control_interface.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/common/dynamic_partition_control_interface.h b/common/dynamic_partition_control_interface.h index 7c2d0b0c..f47958df 100644 --- a/common/dynamic_partition_control_interface.h +++ b/common/dynamic_partition_control_interface.h @@ -26,6 +26,7 @@ #include "update_engine/common/action.h" #include "update_engine/common/cleanup_previous_update_action_delegate.h" #include "update_engine/common/error_code.h" +#include "update_engine/common/prefs_interface.h" #include "update_engine/update_metadata.pb.h" namespace chromeos_update_engine { @@ -42,7 +43,6 @@ struct FeatureFlag { }; class BootControlInterface; -class PrefsInterface; class DynamicPartitionControlInterface { public: |