summaryrefslogtreecommitdiff
path: root/libutils/String16_test.cpp
AgeCommit message (Collapse)Author
2021-06-10Check for overflow in String16::append and String16::insert.Elliott Hughes
Bug: http://b/178802681 Bug: http://b/178821065 Test: new tests Change-Id: I2352ea4c65e3f29e44e2ad6cad20ad610ceace1f
2021-05-12Remove String16::remove tests.Elliott Hughes
These tests are only in internal right now, preventing me from removing this function entirely. So let's get them out of the way... Test: treehugger Ignore-AOSP-First: workaround for presubmit merge conflict Bug: http://b/35267372 Change-Id: Ib5de178ffad833c87e8e93bfd33e85a0ff504ac0
2021-04-08Remove String16::makeLower().Elliott Hughes
If you need to do a case transformation for a Unicode string, you need to use icu4c. This only worked for ASCII, which is just silly. Luckily it doesn't seem to be used anywhere. Test: treehugger Change-Id: I4a864823ec35a0b57b50909587cc3efac3f531a7 Merged-In: I4a864823ec35a0b57b50909587cc3efac3f531a7 (cherry picked from commit c74d97c85442ea4d2bde2505750ab4bfe98ed325)
2020-11-12Merge "libutils: add unit tests for invalid utf-8 and utf-16 strings" am: ↵Devin Moore
eb85221dcf am: c21e63ea26 am: ddc33e4f85 am: cc2f1917ac Original change: https://android-review.googlesource.com/c/platform/system/core/+/1470423 Change-Id: Ie9f981fb869868a3acc2ca60e1a1a727b0905ad5
2020-11-10libutils: add unit tests for invalid utf-8 and utf-16 stringsDevin Moore
Characters get dropped during the conversionis between 8 and 16. Test: atest libutils_test Change-Id: Ie76dd38e97968137555ba2ab7ce188c9122ed06e
2020-05-28String16::remove - avoid overflowSteven Moreland
Bug: 156999009 Test: libutils_test (cases added) Change-Id: Iad46d95d9848928ba81000090b2fe9aec1e5eaac
2019-09-05Reland "libutils: Introduce StaticString16""Vic Yang
This reverts commit 1270e4fbf17402fb01dbfa7928a654d41d8553ee. Bug: 138856262 Test: Run unit tests. Change-Id: I37be01d7d4f98a83078870cb0917275336fa2bbd Merged-In: I8da93f2c9b95183e32d4a2ea895f90c449abbe4d
2019-08-30Revert "Reland "libutils: Introduce StaticString16"""Kevin Han
This reverts commit c55ac92bd6b6f14778758893730415f5328da530. Reason for revert: Breaks down-stream branches. See b/140315617 Change-Id: I4937fdf4bdcc7a44d5f10700ecf2d5e96aef7d27 Merged-In: I8da93f2c9b95183e32d4a2ea895f90c449abbe4d
2019-08-30Reland "libutils: Introduce StaticString16""Vic Yang
This time with old branches excluded. Bug: 138856262 Test: Run unit tests. Change-Id: Id0bb1d54b71e38244d64f1b684db1fda81de854c Merged-In: I8da93f2c9b95183e32d4a2ea895f90c449abbe4d
2019-08-29Revert "libutils: Introduce StaticString16"Vic Yang
This reverts commit d4cb4894348818b90457d94580ed4d611c5d11b0. Reason for revert: Breaking aosp_bonito-userdebug Change-Id: Iea72f39d40f476002ce0ad6b5ce3b4e1ca570de7
2019-08-09libutils: Introduce StaticString16Vic Yang
This is a backward compatible implementation of compile time constructed String16 support. As much as we'd like a regular constexpr constructor for String16, we want to make sure the regular non-static String16 does not regress. We also need to make sure prebuilts built with previous version of String16 still works with new libutils. This means we cannot change the size of String16 objects and we cannot make anything virtual. To add a flag to indicate whether a String16 is static without increasing the size of non-static String16 objects, we repurpose a reserved field in SharedBuffer as "for client use". With this, we can tag every String16 and perform memory operation differently based on how the underlying buffers are allocated. By using StaticString16, we are able to eliminate the runtime construction of a String16 and move it out of .bss section. Bug: 138856262 Test: Run newly added unit tests. Change-Id: I72bb8dc27a59b9ef34e0d934bc1e00b0f675855a