diff options
| author | Josh Gao <jmgao@google.com> | 2017-09-13 13:40:57 -0700 |
|---|---|---|
| committer | Josh Gao <jmgao@google.com> | 2017-09-27 14:36:08 -0700 |
| commit | c78ecca70b44be14b06f526f17db199773ad160c (patch) | |
| tree | 49193de964c49fba4f05f740d46be37b3cb404ac /trusty/coverage/coverage_test.cpp | |
| parent | 1bd8498fc89d14b98e64142e07ad0c35c3bbffed (diff) | |
Revert "adb: fix deadlock between transport_unref and usb_close."
This reverts commit 7e197ef83307ffcf2f55d1b8a603d0d3bd2e1d4d.
The mutex lock in transport_unref hides a race that seems otherwise
hard to fix. Specifically, there's no synchronization between acquiring
a transport and attaching it to an asocket*, leading to badness if the
transport is closed in between the two operations.
Fix the original problem the reverted patch addressed by manually
unlocking before calling unregister_usb_transport.
Bug: http://b/65419665
Bug: 64709603 (presubmit balking at the line above)
Test: python test_device.py
Change-Id: I0ed0044129b1671b2c5dd1b9fa2e70a9b4475dc5
(cherry picked from commit e48ecce671a2ab6647cc26a3cb11163aec0b712c)
Diffstat (limited to 'trusty/coverage/coverage_test.cpp')
0 files changed, 0 insertions, 0 deletions