summaryrefslogtreecommitdiff
path: root/trusty/coverage/coverage_test.cpp
diff options
context:
space:
mode:
authorTom Cherry <tomcherry@google.com>2020-04-10 13:48:05 -0700
committerTom Cherry <tomcherry@google.com>2020-04-10 13:48:05 -0700
commit5f4c79f510f66b85c2f9a35b173fc3471c68f55e (patch)
treef8565badc55abb536809ab1cff1218ad42d22b32 /trusty/coverage/coverage_test.cpp
parent7ef143fc84b80b9e3e040b129e0fe9d8b05fc15c (diff)
liblog: cleanup TODOs in tests
1) log_msg.msg() will never be nullptr, unless logd sends an invalid response, so it's the right idea to ASSERT() that this is true instead of just checking and continuing. 2) Even though liblog.too_big_payload is tautological, there's no reason not to test it, in case the assumptions that make it tautological change. 3) We're not too worried about the return value of logging functions or that liblog prevents them from being written (anyone can write their own values to logd after all). Test: liblog-unit-tests Change-Id: I144cc7cf45c164ea5f04e0786ff0e298fd626f07
Diffstat (limited to 'trusty/coverage/coverage_test.cpp')
0 files changed, 0 insertions, 0 deletions