diff options
| author | mtk16036 <squall.ko@mediatek.com> | 2019-05-31 19:05:22 +0800 |
|---|---|---|
| committer | Suren Baghdasaryan <surenb@google.com> | 2019-06-12 19:27:14 +0000 |
| commit | 540b1556c92204d6a553b6b2ac2a426a2042e390 (patch) | |
| tree | c4d54a2ee49294aaaf5474fcfa12f1368663a975 /trusty/coverage/coverage.cpp | |
| parent | 607611e01692e66287d8a7ba58ef3182fa3e1d28 (diff) | |
race condition in libprocessgroup
while enable fdsan (file descriptor sanitizer),
fdsan report use-after-close error after boot complete (sedom).
Because, in SetCgroupAction::EnableResourceCaching() currently has a data race against all the
use fd_ functions like SetCgroupAction::ExecuteForProcess(uid_t uid, pid_t pid) etc.
ThreadA | ThreadB
-------------------------------------------------------------------------------------------------
in SetCgroupAction::EnableResourceCaching() | in SetCgroupAction::ExecuteForProcess(...)
-------------------------------------------------------------------------------------------------
| in SetCgroupAction::AddTidToCgroup(int tid, int fd)
-------------------------------------------------------------------------------------------------
fd_ = std::move(fd); /*modified fd_ value*/ |
-------------------------------------------------------------------------------------------------
| write(fd) /* crash here, fd is closed by ThreadA*/
-------------------------------------------------------------------------------------------------
So, add mutex lock to protect fd_ data race.
Bug: 134120826
Test: auto test, run the adb reboot test 100 times and no fdsan error report on libprocessgroup
Merged-In: Iccf2f705e030f79324f1164509e715dc5be825de
Change-Id: Iccf2f705e030f79324f1164509e715dc5be825de
Diffstat (limited to 'trusty/coverage/coverage.cpp')
0 files changed, 0 insertions, 0 deletions