summaryrefslogtreecommitdiff
path: root/logd/SerializedLogChunkTest.cpp
diff options
context:
space:
mode:
authorTom Cherry <tomcherry@google.com>2020-10-06 15:54:26 -0700
committerTom Cherry <tomcherry@google.com>2020-10-06 15:54:26 -0700
commit340afd38cba548fc25392bf43bb179faefac89bc (patch)
tree7a02ee54a1c1fff2532bb9a2168c999ac588b8e3 /logd/SerializedLogChunkTest.cpp
parent1bacb2c389efda4f6a946a1aa271470acb65800f (diff)
logd: fix bad test assumptions
SerializedLogChunk.three_logs assumes that log buffers are zero-initialized, but they are not. This causes test failures on host. Test: this test passes Change-Id: I0dfa282bdc36eaa4e8e39d85c5227f717b45ec2a
Diffstat (limited to 'logd/SerializedLogChunkTest.cpp')
-rw-r--r--logd/SerializedLogChunkTest.cpp10
1 files changed, 3 insertions, 7 deletions
diff --git a/logd/SerializedLogChunkTest.cpp b/logd/SerializedLogChunkTest.cpp
index 3b451252d..862c3fe31 100644
--- a/logd/SerializedLogChunkTest.cpp
+++ b/logd/SerializedLogChunkTest.cpp
@@ -99,13 +99,9 @@ TEST(SerializedLogChunk, three_logs) {
"\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF" // Timestamp
"\x0C\x00last message"; // msg_len + message
- for (size_t i = 0; i < chunk_size; ++i) {
- if (i < sizeof(expected_buffer_data)) {
- EXPECT_EQ(static_cast<uint8_t>(expected_buffer_data[i]), chunk.data()[i])
- << "position: " << i;
- } else {
- EXPECT_EQ(0, chunk.data()[i]) << "position: " << i;
- }
+ for (size_t i = 0; i < sizeof(expected_buffer_data); ++i) {
+ EXPECT_EQ(static_cast<uint8_t>(expected_buffer_data[i]), chunk.data()[i])
+ << "position: " << i;
}
}