summaryrefslogtreecommitdiff
path: root/libutils/Unicode.cpp
diff options
context:
space:
mode:
authorTom Cherry <tomcherry@google.com>2017-06-19 17:41:41 -0700
committerTom Cherry <tomcherry@google.com>2017-06-20 21:22:00 +0000
commitd43b615216fb1656fb5234e8202aa3ed7b37fda7 (patch)
tree03c58b382c162fc9128f86b741d24f8250246a55 /libutils/Unicode.cpp
parentc6b07ec0953af6ab9acf430ff57fe61c5130c3b8 (diff)
ueventd: remove PlatformDeviceList
In order to create symlinks for USB and block devices, the path for their parent platform device must be known. Previously, ueventd would save each platform device that it encounters to a list and query this list when creating the symlinks. That, however, is racy because the uevent socket does not differentiate uevents from device_init() and uevents sent by the kernel when probing a device first the first time. The below scenario is the faulty case: 1) Kernel probes parent platform device for a block device 2) ueventd calls device_init() and starts processing uevents 3) Kernel probes block device and sends its uevents 4) ueventd picks up the block device uevent during its uevent processing, without yet regenerating the platform device uevent, causing improper symlinks to be created. This change stops storing the platform devices in a list, and instead traverses up the directory structure for each USB or block device until it reaches a platform device, defined as one whose subsystem is the platform bus. This fixes the race and simplifies the ueventd code. Bug: 62436493 Bug: 62681642 Test: Boot bullhead Test: Boot sailfish Test: Boot hikey + hotplug/unplug sdcard Merged-In: I21636355d8e434f30e0cba568598a6cf139e67f9 Change-Id: I21636355d8e434f30e0cba568598a6cf139e67f9
Diffstat (limited to 'libutils/Unicode.cpp')
0 files changed, 0 insertions, 0 deletions