diff options
author | Josh Gao <jmgao@google.com> | 2018-08-07 14:14:21 -0700 |
---|---|---|
committer | Josh Gao <jmgao@google.com> | 2018-08-07 14:24:36 -0700 |
commit | 4039051d6ddb02324204930fb86d9d0fe405b3fb (patch) | |
tree | f41a7a9dadbadaba8962fcf7a18cd18943abdb5d /libutils/Unicode.cpp | |
parent | 6b0ecdab159e078d37fedcaad300db411f49eadc (diff) |
adb: clean up handle_host_request.
Previously, we were returning the result of SendOkay/SendFail in a few
places after handling a host request, which is incorrect for two
reasons. First, the return type of SendOkay/SendFail is bool, and
handle_host_request was expected to return 0 on success. Second, we
don't care if the SendOkay fails; if we got to that point, we're done
with the request, regardless of whether we succeeded to report our
result. The result of this was a spurious failure result reported after
the initial result, which was ignored by the adb client.
Test: manually straced adb server
Test: python test_adb.py
Test: python test_device.py
Change-Id: I7d45ba527e1faccbbae5b15e7a0d1557b0a84858
Diffstat (limited to 'libutils/Unicode.cpp')
0 files changed, 0 insertions, 0 deletions