diff options
| author | Eric Biggers <ebiggers@google.com> | 2021-07-22 12:56:39 -0700 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2021-07-22 19:46:29 -0700 |
| commit | 1fda6f1bf146238b3180fc4fb20fbb926762f0f0 (patch) | |
| tree | 89c6fa2f575fdbb0f16f3fd9f63670e5ca34098e /libutils/RefBase.cpp | |
| parent | 830ea32e77292d4584977ac8162dcdbc92de613a (diff) | |
Revert "init: make reboot_on_failure not apply to manually stopped services"
This reverts commit 1c51525f6686a97e32c166facad93fc97eacf0f9 because it
accidentally made reboot_on_failure be a no-op for all services. This
is because Reap() itself calls KillProcessGroup() on devices with a
vendor level >= R, which in turn sets SVC_STOPPING. I had overlooked
this somehow, probably because I didn't consider that a service can
consist of multiple processes.
It turns out that real FDE devices don't actually need the above commit
because FDE devices aren't allowed to have updatable apexes enabled, and
without updatable apexes enabled, apexd exits automatically and
therefore doesn't have to be stopped. This can be verified by using the
aosp_cf_x86_phone_noapex build target, rather than aosp_cf_x86_phone
which I had used for testing before. So just revert it for now.
Bug: 194370048
Change-Id: I90eddf2a87397449b241e5acaaa8d4a4241d73a9
(cherry picked from commit d14a178d01fd1690cf8c9f69dd8672b29f946a10)
Merged-In: I90eddf2a87397449b241e5acaaa8d4a4241d73a9
Diffstat (limited to 'libutils/RefBase.cpp')
0 files changed, 0 insertions, 0 deletions