diff options
| author | George Burgess IV <gbiv@google.com> | 2017-05-16 16:31:31 -0700 |
|---|---|---|
| committer | Mark Salyzyn <salyzyn@google.com> | 2017-05-31 14:41:22 +0000 |
| commit | 6466ced8f6e31e975a716694dc33db86169a1e2d (patch) | |
| tree | f68a8dce874953046b8d5e20430b7cee76960701 /libunwindstack/tests/MemoryFileTest.cpp | |
| parent | 1e63347425c035576a206919cedf2d2c1f9acfd7 (diff) | |
logging: make LOG(FATAL) always run with the static analyzer.
::android::base::GetMinimumLogSeverity() is defined externally, so the
static analyzer was allowed to assume that we continue executing after a
LOG(FATAL).
I manually audited all of the code I have access to, and the only
"change the minimum log severity" statements I can see keep FATAL
enabled (...and continuing after a FATAL is highly sketchy to me
anyway).
(I'm sure I tested this at some point in making the previous patch. I
probably broke it in a refactor before sending it out for review; my
bad. :) )
Bug: None
Test: m without the static-analyzer builds; m with it yields fewer
false positives.
Change-Id: I216cd2034e1daa8d6f6c5e776f64b4cce88bb938
Diffstat (limited to 'libunwindstack/tests/MemoryFileTest.cpp')
0 files changed, 0 insertions, 0 deletions