diff options
| author | Josh Gao <jmgao@google.com> | 2017-10-18 11:44:51 -0700 |
|---|---|---|
| committer | Josh Gao <jmgao@google.com> | 2017-11-15 15:38:13 -0800 |
| commit | ef35aa5d40b6404baf702a58527f1cd3a9f42f19 (patch) | |
| tree | 99f7797b05c934a10fdcb058b025a0304ca2b6f5 /libunwindstack/tests/MemoryBufferTest.cpp | |
| parent | 29c5378e91720b7befabc91fbab0f25d59a23bf1 (diff) | |
unwindstack: rename Memory::Read to ReadFully.
Rename Memory::Read to ReadFully to match its semantics with that of
android::base. ReadPartially will be renamed to Read in a follow up
commit, kept intentionally separate so that there aren't any callers
accidentally switched from ReadFully to Read.
Test: treehugger
Change-Id: I7d845ac5244c3025d92c8512e960e5d0d1da05af
Diffstat (limited to 'libunwindstack/tests/MemoryBufferTest.cpp')
| -rw-r--r-- | libunwindstack/tests/MemoryBufferTest.cpp | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/libunwindstack/tests/MemoryBufferTest.cpp b/libunwindstack/tests/MemoryBufferTest.cpp index be5a52003..350ffaee8 100644 --- a/libunwindstack/tests/MemoryBufferTest.cpp +++ b/libunwindstack/tests/MemoryBufferTest.cpp @@ -36,7 +36,7 @@ class MemoryBufferTest : public ::testing::Test { TEST_F(MemoryBufferTest, empty) { ASSERT_EQ(0U, memory_->Size()); std::vector<uint8_t> buffer(1024); - ASSERT_FALSE(memory_->Read(0, buffer.data(), 1)); + ASSERT_FALSE(memory_->ReadFully(0, buffer.data(), 1)); ASSERT_EQ(nullptr, memory_->GetPtr(0)); ASSERT_EQ(nullptr, memory_->GetPtr(1)); } @@ -55,7 +55,7 @@ TEST_F(MemoryBufferTest, write_read) { } std::vector<uint8_t> buffer(memory_->Size()); - ASSERT_TRUE(memory_->Read(0, buffer.data(), buffer.size())); + ASSERT_TRUE(memory_->ReadFully(0, buffer.data(), buffer.size())); for (size_t i = 0; i < buffer.size(); i++) { ASSERT_EQ(i, buffer[i]) << "Failed at byte " << i; } @@ -64,18 +64,18 @@ TEST_F(MemoryBufferTest, write_read) { TEST_F(MemoryBufferTest, read_failures) { memory_->Resize(100); std::vector<uint8_t> buffer(200); - ASSERT_FALSE(memory_->Read(0, buffer.data(), 101)); - ASSERT_FALSE(memory_->Read(100, buffer.data(), 1)); - ASSERT_FALSE(memory_->Read(101, buffer.data(), 2)); - ASSERT_FALSE(memory_->Read(99, buffer.data(), 2)); - ASSERT_TRUE(memory_->Read(99, buffer.data(), 1)); + ASSERT_FALSE(memory_->ReadFully(0, buffer.data(), 101)); + ASSERT_FALSE(memory_->ReadFully(100, buffer.data(), 1)); + ASSERT_FALSE(memory_->ReadFully(101, buffer.data(), 2)); + ASSERT_FALSE(memory_->ReadFully(99, buffer.data(), 2)); + ASSERT_TRUE(memory_->ReadFully(99, buffer.data(), 1)); } TEST_F(MemoryBufferTest, read_failure_overflow) { memory_->Resize(100); std::vector<uint8_t> buffer(200); - ASSERT_FALSE(memory_->Read(UINT64_MAX - 100, buffer.data(), 200)); + ASSERT_FALSE(memory_->ReadFully(UINT64_MAX - 100, buffer.data(), 200)); } TEST_F(MemoryBufferTest, ReadPartially) { |