diff options
author | Treehugger Robot <treehugger-gerrit@google.com> | 2020-06-16 22:22:13 +0000 |
---|---|---|
committer | Gerrit Code Review <noreply-gerritcodereview@google.com> | 2020-06-16 22:22:13 +0000 |
commit | 2ab39411eb42461fe01f2cb993a4fb8c6c58c8a8 (patch) | |
tree | 5a0499fa52e4af5eab3aa79334a2f16371c038a0 /libmodprobe/libmodprobe_ext.cpp | |
parent | f9033832cfc203de9453f016b2e497789e017588 (diff) | |
parent | 1ab2c02324972e7c3355ee40e52549acd0e345f9 (diff) |
Merge "libmodprobe: improve error reporting."
Diffstat (limited to 'libmodprobe/libmodprobe_ext.cpp')
-rw-r--r-- | libmodprobe/libmodprobe_ext.cpp | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/libmodprobe/libmodprobe_ext.cpp b/libmodprobe/libmodprobe_ext.cpp index 84f71506a..fb1f5e73e 100644 --- a/libmodprobe/libmodprobe_ext.cpp +++ b/libmodprobe/libmodprobe_ext.cpp @@ -35,7 +35,7 @@ bool Modprobe::Insmod(const std::string& path_name, const std::string& parameter android::base::unique_fd fd( TEMP_FAILURE_RETRY(open(path_name.c_str(), O_RDONLY | O_NOFOLLOW | O_CLOEXEC))); if (fd == -1) { - LOG(ERROR) << "Could not open module '" << path_name << "'"; + PLOG(ERROR) << "Could not open module '" << path_name << "'"; return false; } @@ -49,7 +49,7 @@ bool Modprobe::Insmod(const std::string& path_name, const std::string& parameter options = options + " " + parameters; } - LOG(INFO) << "Loading module " << path_name << " with args \"" << options << "\""; + LOG(INFO) << "Loading module " << path_name << " with args '" << options << "'"; int ret = syscall(__NR_finit_module, fd.get(), options.c_str(), 0); if (ret != 0) { if (errno == EEXIST) { @@ -57,7 +57,7 @@ bool Modprobe::Insmod(const std::string& path_name, const std::string& parameter module_loaded_.emplace(canonical_name); return true; } - LOG(ERROR) << "Failed to insmod '" << path_name << "' with args '" << options << "'"; + PLOG(ERROR) << "Failed to insmod '" << path_name << "' with args '" << options << "'"; return false; } |