diff options
author | Christopher Ferris <cferris@google.com> | 2017-09-01 11:17:16 -0700 |
---|---|---|
committer | Christopher Ferris <cferris@google.com> | 2017-09-05 14:30:22 -0700 |
commit | 5f118519fd323a0c71b54de9279e8a9ea6a56271 (patch) | |
tree | 3ce288c58ab8d5a6aa1d3c307def1f0f1019ae7a /libbacktrace/UnwindStackMap.cpp | |
parent | 9638729a9d9e3cbbbe1bb2784e774fef0f2e6a54 (diff) |
Add a method to share the process memory object.
New function to create the process memory object. This allows for
a future where different remote process memory objects could be created
depending on the way remote memory can be created. Even different local
memory objects that access memory without doing any checks.
It also allows MemoryRange objects to share one single process memory object
and could help if the process memory object caches data.
Small changes to MapInfo::CreateMemory to when some errors are detected.
- Always check if the map is a device map, instead of only if the name
is not empty.
- Check if a memory map is readable before creating the memory from process
memory.
Bug: 23762183
Test: Ran unit tests, unwound on device using the new code.
Change-Id: I12a93c2dc19639689a528ec41c67bfac74d431b3
Diffstat (limited to 'libbacktrace/UnwindStackMap.cpp')
-rw-r--r-- | libbacktrace/UnwindStackMap.cpp | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/libbacktrace/UnwindStackMap.cpp b/libbacktrace/UnwindStackMap.cpp index ba9fd87d7..d4a2444dc 100644 --- a/libbacktrace/UnwindStackMap.cpp +++ b/libbacktrace/UnwindStackMap.cpp @@ -36,6 +36,9 @@ bool UnwindStackMap::Build() { stack_maps_.reset(new unwindstack::RemoteMaps(pid_)); } + // Create the process memory object. + process_memory_ = unwindstack::Memory::CreateProcessMemory(pid_); + if (!stack_maps_->Parse()) { return false; } @@ -68,7 +71,7 @@ void UnwindStackMap::FillIn(uintptr_t addr, backtrace_map_t* map) { if (map_info == nullptr) { return; } - unwindstack::Elf* elf = map_info->GetElf(pid_, true); + unwindstack::Elf* elf = map_info->GetElf(process_memory_, true); map->load_bias = elf->GetLoadBias(); } |