summaryrefslogtreecommitdiff
path: root/init/service_utils.cpp
diff options
context:
space:
mode:
authorElliott Hughes <enh@google.com>2020-07-28 11:09:03 -0700
committerElliott Hughes <enh@google.com>2020-07-28 11:09:03 -0700
commite79b8c2092308b63202666af4dae16600c318b22 (patch)
tree33eb30ecae28ac84a0e57a23853244a6b2436455 /init/service_utils.cpp
parent5ce349927da512ee043aae119e73842db3283a18 (diff)
Cleanup for #inclusivefixit.
Test: treehugger Change-Id: I651689e2d59c017a9bde44251d95b57e594f0b5b
Diffstat (limited to 'init/service_utils.cpp')
-rw-r--r--init/service_utils.cpp11
1 files changed, 6 insertions, 5 deletions
diff --git a/init/service_utils.cpp b/init/service_utils.cpp
index 05e632b68..f2383d7a6 100644
--- a/init/service_utils.cpp
+++ b/init/service_utils.cpp
@@ -60,13 +60,14 @@ Result<void> EnterNamespace(int nstype, const char* path) {
Result<void> SetUpMountNamespace(bool remount_proc, bool remount_sys) {
constexpr unsigned int kSafeFlags = MS_NODEV | MS_NOEXEC | MS_NOSUID;
- // Recursively remount / as slave like zygote does so unmounting and mounting /proc
- // doesn't interfere with the parent namespace's /proc mount. This will also
- // prevent any other mounts/unmounts initiated by the service from interfering
- // with the parent namespace but will still allow mount events from the parent
+ // Recursively remount / as MS_SLAVE like zygote does so that
+ // unmounting and mounting /proc doesn't interfere with the parent
+ // namespace's /proc mount. This will also prevent any other
+ // mounts/unmounts initiated by the service from interfering with the
+ // parent namespace but will still allow mount events from the parent
// namespace to propagate to the child.
if (mount("rootfs", "/", nullptr, (MS_SLAVE | MS_REC), nullptr) == -1) {
- return ErrnoError() << "Could not remount(/) recursively as slave";
+ return ErrnoError() << "Could not remount(/) recursively as MS_SLAVE";
}
// umount() then mount() /proc and/or /sys