diff options
| author | Tom Cherry <tomcherry@google.com> | 2019-07-09 13:33:36 -0700 |
|---|---|---|
| committer | Tom Cherry <tomcherry@google.com> | 2019-07-15 12:17:30 -0700 |
| commit | 2e4c85f157bd52d4daaf0b4e67280aa72f98da07 (patch) | |
| tree | bb553134c66c156072cc747c99d93812acc5bc5f /init/service_parser.h | |
| parent | 8a779ee959996b413a8539d2a571e34803be0bf5 (diff) | |
init: clean up file / socket descriptor creation
clang-tidy hinted that some of this code wasn't right. Looking
deeper, there is really not much related to file and socket
descriptors, except that they're published in similar ways to the
environment. All of the abstraction into a 'Descriptor' class takes
us further away from specifying what we really mean.
This removes that abstraction, adds stricter checks and better errors
for parsing init scripts, reports sockets and files that are unable to
be acquired before exec, and updates the README.md for the passcred
option.
Test: build, logd (uses files and sockets) works
Change-Id: I59e611e95c85bdbefa779ef69b32b9dd4ee203e2
Diffstat (limited to 'init/service_parser.h')
| -rw-r--r-- | init/service_parser.h | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/init/service_parser.h b/init/service_parser.h index 5ad26ef6c..bca07390b 100644 --- a/init/service_parser.h +++ b/init/service_parser.h @@ -81,9 +81,6 @@ class ServiceParser : public SectionParser { Result<void> ParseWritepid(std::vector<std::string>&& args); Result<void> ParseUpdatable(std::vector<std::string>&& args); - template <typename T> - Result<void> AddDescriptor(std::vector<std::string>&& args); - bool IsValidName(const std::string& name) const; ServiceList* service_list_; |