diff options
author | Tom Cherry <tomcherry@google.com> | 2018-02-05 08:01:54 -0800 |
---|---|---|
committer | Tom Cherry <tomcherry@google.com> | 2018-02-05 08:01:54 -0800 |
commit | 880d566400d38743e75be0ae88b142bc5ba27c57 (patch) | |
tree | a58259d046dbf7e8ddb027c7d3b797204ee1980c /init/builtins.cpp | |
parent | 01ba1157325a5e6572122f5d46cfd0376b75aa98 (diff) |
init: add TODO for mount operations.
mount operations should be done in vendor init context, but their
complexity currently limits this. Add a TODO to make this reason
clear to those viewing the code.
Bug: 72488820
Test: N/A
Change-Id: I8b6dd92aa79f31dc24603559ed6de0815facfcba
Diffstat (limited to 'init/builtins.cpp')
-rw-r--r-- | init/builtins.cpp | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/init/builtins.cpp b/init/builtins.cpp index 413d11eb0..caf0c3fe4 100644 --- a/init/builtins.cpp +++ b/init/builtins.cpp @@ -1030,6 +1030,10 @@ const BuiltinFunctionMap::Map& BuiltinFunctionMap::map() const { {"load_system_props", {0, 0, {false, do_load_system_props}}}, {"loglevel", {1, 1, {false, do_loglevel}}}, {"mkdir", {1, 4, {true, do_mkdir}}}, + // TODO: Do mount operations in vendor_init. + // mount_all is currently too complex to run in vendor_init as it queues action triggers, + // imports rc scripts, etc. It should be simplified and run in vendor_init context. + // mount and umount are run in the same context as mount_all for symmetry. {"mount_all", {1, kMax, {false, do_mount_all}}}, {"mount", {3, kMax, {false, do_mount}}}, {"umount", {1, 1, {false, do_umount}}}, |