diff options
author | Tom Cherry <tomcherry@google.com> | 2017-04-19 15:31:58 -0700 |
---|---|---|
committer | Tom Cherry <tomcherry@google.com> | 2017-04-21 18:26:40 -0700 |
commit | 30a6f276fd8850b0a78689d7bff3cb06a18cb286 (patch) | |
tree | 6d07dc78662207e7300c42c9362dc7b198d98194 /init/builtins.cpp | |
parent | a0bf415cad6dddcc1cdb154a95c795b5a8ecb7aa (diff) |
init: clean up the SectionParser interface and Parser class
Remove the dependency on Action and Service from what should be a
generic Parser class.
Make ActionParser, ImportParser, and ServiceParser take a pointer to
their associated classes instead of accessing them through a
singleton.
Misc fixes to SectionParser Interface:
1) Make SectionParser::ParseLineSection() non-const as it always should
have been.
2) Use Rvalue references where appropriate
3) Remove extra std::string& filename in SectionParser::EndFile()
4) Only have SectionParser::ParseSection() as pure virtual
Document SectionParser.
Make ImportParser report the filename and line number of failed imports.
Make ServiceParser report the filename and line number of duplicated services.
Test: Boot bullhead
Change-Id: I86568a5b375fb4f27f4cb235ed1e37635f01d630
Diffstat (limited to 'init/builtins.cpp')
-rw-r--r-- | init/builtins.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/init/builtins.cpp b/init/builtins.cpp index 43eb42075..87d4e81af 100644 --- a/init/builtins.cpp +++ b/init/builtins.cpp @@ -390,7 +390,7 @@ static void import_late(const std::vector<std::string>& args, size_t start_index // Turning this on and letting the INFO logging be discarded adds 0.2s to // Nexus 9 boot time, so it's disabled by default. - if (false) parser.DumpState(); + if (false) DumpState(); } /* mount_fstab |