diff options
author | Robin Hsu <robinhsu@google.com> | 2019-11-07 13:44:08 +0800 |
---|---|---|
committer | Robin Hsu <robinhsu@google.com> | 2019-11-12 18:52:29 +0800 |
commit | 48c9f6196ffb387f423c7f711df079baffeed6d6 (patch) | |
tree | 5f8d9b3cb342b46f42ee3b64c4664270a49c07db /fastboot/device/variables.cpp | |
parent | d9381651ee52ca6a081458d8b98806eda5aa579e (diff) |
libsparse: fix memory leak in output_file_close()
Fix memory leak in output_file_close():
Arguable whose resposibility to free structs allocated inside a file
struct (the caller or the library function), but the following protocol
(i.e. this fix) would better prevent memory leaks:
1) output_file_close() function will free those structs inside a file struct,
right before closing the file.
* Note: those structs are originally allocated by other libsparse function.
2) If the caller wants to clean up those struct inside a file struct,
it may. Just free those structs, and set the pointer to NULL.
Afterward, when file_close()'s are called, they won't be free'ed twice.
Bug: 142483439
Test: verified by script MemLeak_LastCmd.sh (attached in Bugnizer)
Change-Id: I8bb9f7c9f7d19268663e2830d1a90d27bd5f99bd
Signed-off-by: Robin Hsu <robinhsu@google.com>
Diffstat (limited to 'fastboot/device/variables.cpp')
0 files changed, 0 insertions, 0 deletions