summaryrefslogtreecommitdiff
path: root/debuggerd/libdebuggerd/utility.cpp
diff options
context:
space:
mode:
authorMark Salyzyn <salyzyn@google.com>2020-02-12 11:43:13 -0800
committerMark Salyzyn <salyzyn@google.com>2020-07-17 07:47:02 -0700
commit93ce58d24a0054dde58343b4b49cc914b8e6eb9b (patch)
treebcedce8a21811fedaecc905897b2b20f0a53fcd3 /debuggerd/libdebuggerd/utility.cpp
parentc9a69b1df11c0e44e58d66e3ca8f13d905007a55 (diff)
fs_mgr: overlayfs: check if scratch device is ext4 dedupe
Do not attempt to mount scratch r/w if it is ext4 dedupe, this causes too much noise and troubling but innocuous error reports. Assumption is we normally try f2fs first on all devices, we only try ext4 first if we do not have f2fs tools, or if the existing filesystem is ext4. That said, we only have to check if it is ext4 dedupe during the first mount attempt, the fallback mount attempt for ext4 is unlikely to need this checking. Changes the output report for a retrofit DAP device from: $ adb remount Disabling verity for /system [libfs_mgr]superblock s_max_mnt_count:65535,/dev/block/by-name/system_b [libfs_mgr]check_fs(): mount(/dev/block/by-name/system_b,/mnt/scratch,ext4)=-1: Invalid argument [libfs_mgr]Running /system/bin/e2fsck on /dev/block/sda6 [libfs_mgr]__mount(source=/dev/block/by-name/system_b,target=/mnt/scratch,type=ext4)=-1: Invalid argument [libfs_mgr]Running /system/bin/fsck.f2fs -a /dev/block/sda6 [libfs_mgr]__mount(source=/dev/block/by-name/system_b,target=/mnt/scratch,type=f2fs)=0: Success Using overlayfs for /system . . . To the more pleasant: $ adb $BL1 remount Disabling verity for /system [libfs_mgr]superblock s_max_mnt_count:65535,/dev/block/by-name/system_b [libfs_mgr]__mount(source=/dev/block/by-name/system_b,target=/mnt/scratch,type=ext4)=0: Success [libfs_mgr]umount(/mnt/scratch) [libfs_mgr]Running /system/bin/fsck.f2fs -a /dev/block/sda6 [libfs_mgr]__mount(source=/dev/block/by-name/system_b,target=/mnt/scratch,type=f2fs)=0: Success Using overlayfs for /system . . . Signed-off-by: Mark Salyzyn <salyzyn@google.com> Test: adb-remount-test.sh Change-Id: Ic8c642912b1bafe0b4210c69c99a1d89fa20f204
Diffstat (limited to 'debuggerd/libdebuggerd/utility.cpp')
0 files changed, 0 insertions, 0 deletions