summaryrefslogtreecommitdiff
path: root/debuggerd/libdebuggerd/utility.cpp
diff options
context:
space:
mode:
authorTom Cherry <tomcherry@google.com>2019-12-11 15:42:16 -0800
committerTom Cherry <tomcherry@google.com>2019-12-11 15:46:47 -0800
commit49a8af7dff2f09e8e2f3c20447a82d49649e83ec (patch)
treeadcb6caabef179cd26338ae338a7e5f792a4b148 /debuggerd/libdebuggerd/utility.cpp
parenta449a1cfd7a5fb392458351d6c9b75d2c5abbe86 (diff)
liblog: do not check loggability of event logs before sending to logd
This code was introduced to help performance by skipping sending these messages to logd when logd would later drop them. However it has multiple flaws: 1) Event logs aren't super common and non-loggable event logs are even less common, so it would be a trivial benefit if any. 2) This code is not particularly safe as written, which is even acknowledged in the comments. 3) This forces processes that write event logs to allocate a rather sizable amount of memory. Therefore, it's better to simply remove this and let logd drop these messages when it receives them. Bug: 139705697 Test: logging works, liblog-unit-tests Change-Id: Ide01574112e173d4922137b3d3868cf8c2c09086
Diffstat (limited to 'debuggerd/libdebuggerd/utility.cpp')
0 files changed, 0 insertions, 0 deletions