diff options
| author | Christopher Ferris <cferris@google.com> | 2020-09-23 15:51:46 -0700 |
|---|---|---|
| committer | Christopher Ferris <cferris@google.com> | 2020-09-24 18:46:23 -0700 |
| commit | b05c472421d9d4dd919926c95a5c1de4eb9a721a (patch) | |
| tree | c8b6009b561bc70170f102a9697ccf42bb997999 /debuggerd/libdebuggerd/backtrace.cpp | |
| parent | de540ad2f1db55eb34adc8af8f5074163ffb9118 (diff) | |
Add arch member into Unwinder object.
This simplifies some of the logic and removes the need to pass an
Arch value to functions that should already know about the arch
it is operating on.
Includes fixes for debuggerd/libbacktrace.
Added new unit tests to cover new cases.
Test: All unit tests pass.
Test: Faked unwinder failing to verify debuggerd error messages display
Test: properly in backtrace and tombstone.
Change-Id: I439fcae0695befcfb1cb4c0a786cc74949d33425
Diffstat (limited to 'debuggerd/libdebuggerd/backtrace.cpp')
| -rw-r--r-- | debuggerd/libdebuggerd/backtrace.cpp | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/debuggerd/libdebuggerd/backtrace.cpp b/debuggerd/libdebuggerd/backtrace.cpp index f5a873c4d..c543a8392 100644 --- a/debuggerd/libdebuggerd/backtrace.cpp +++ b/debuggerd/libdebuggerd/backtrace.cpp @@ -18,8 +18,9 @@ #include "libdebuggerd/backtrace.h" -#include <errno.h> #include <dirent.h> +#include <errno.h> +#include <inttypes.h> #include <limits.h> #include <stddef.h> #include <stdio.h> @@ -65,7 +66,11 @@ void dump_backtrace_thread(int output_fd, unwindstack::Unwinder* unwinder, unwinder->SetRegs(thread.registers.get()); unwinder->Unwind(); if (unwinder->NumFrames() == 0) { - _LOG(&log, logtype::THREAD, "Unwind failed: tid = %d", thread.tid); + _LOG(&log, logtype::THREAD, "Unwind failed: tid = %d\n", thread.tid); + if (unwinder->LastErrorCode() != unwindstack::ERROR_NONE) { + _LOG(&log, logtype::THREAD, " Error code: %s\n", unwinder->LastErrorCodeString()); + _LOG(&log, logtype::THREAD, " Error address: 0x%" PRIx64 "\n", unwinder->LastErrorAddress()); + } return; } |