diff options
author | Christopher Ferris <cferris@google.com> | 2019-09-20 14:18:55 -0700 |
---|---|---|
committer | Christopher Ferris <cferris@google.com> | 2019-09-20 15:07:03 -0700 |
commit | 11555f0961fd923feba9cd0e125eef4544bc72e8 (patch) | |
tree | 9bc2ff642187d9a5ce1f40779b37784e23aa617d /debuggerd/debuggerd_test.cpp | |
parent | 03642ad8b88a48fc22d714c9d0e4f2a368d356ac (diff) |
Increase timeouts.
There is still some flakiness, so increase the timeout values.
Also remove the TEMP_FAILURE_RETRY macro usage in TIMEOUT calls.
That macro disables the ability of the alarm code to interrupt
the system call.
Bug: 141045754
Test: Unit tests pass.
Change-Id: Ia3c95dccc3076a3fd5ef6432097a57e4ccee4df3
Diffstat (limited to 'debuggerd/debuggerd_test.cpp')
-rw-r--r-- | debuggerd/debuggerd_test.cpp | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/debuggerd/debuggerd_test.cpp b/debuggerd/debuggerd_test.cpp index c617c6ccc..c9a193c62 100644 --- a/debuggerd/debuggerd_test.cpp +++ b/debuggerd/debuggerd_test.cpp @@ -195,9 +195,7 @@ void CrasherTest::StartIntercept(unique_fd* output_fd, DebuggerdDumpType interce void CrasherTest::FinishIntercept(int* result) { InterceptResponse response; - // Timeout for tombstoned intercept is 10 seconds. - ssize_t rc = - TIMEOUT(20, TEMP_FAILURE_RETRY(read(intercept_fd.get(), &response, sizeof(response)))); + ssize_t rc = TIMEOUT(30, read(intercept_fd.get(), &response, sizeof(response))); if (rc == -1) { FAIL() << "failed to read response from tombstoned: " << strerror(errno); } else if (rc == 0) { @@ -244,7 +242,7 @@ void CrasherTest::FinishCrasher() { void CrasherTest::AssertDeath(int signo) { int status; - pid_t pid = TIMEOUT(10, TEMP_FAILURE_RETRY(waitpid(crasher_pid, &status, 0))); + pid_t pid = TIMEOUT(30, waitpid(crasher_pid, &status, 0)); if (pid != crasher_pid) { printf("failed to wait for crasher (expected pid %d, return value %d): %s\n", crasher_pid, pid, strerror(errno)); |