diff options
| author | Łukasz Szymczyk <lukasz.szymczyk@sonymobile.com> | 2015-01-15 14:21:54 +0100 |
|---|---|---|
| committer | Narayan Kamath <narayan@google.com> | 2015-04-20 09:49:26 +0000 |
| commit | e1d5a6aa5c4fc150c990bd160548aa8738bc51dc (patch) | |
| tree | 179ec28c64a68b0944fffa77615f4f64b924cf81 /base/errors_unix.cpp | |
| parent | 34c91eddb09ab86ffe6c965b25c5253c37ded227 (diff) | |
Reserve space on disk using fallocate
There were crashes when android failed to extract
zip archives due to out of free space on disk, with stacks like:
#00 pc 00000000000156b0 /system/lib64/libc.so (memcpy+176)
#01 pc 000000000002e5b8 /system/lib64/libandroidfw.so
#02 pc 000000000002f488 /system/lib64/libandroidfw.so (ExtractToMemory+328)
#03 pc 000000000002f5c8 /system/lib64/libandroidfw.so (ExtractEntryToFile+268)
#04 pc 00000000000287d8 /system/lib64/libandroidfw.so (android::ZipFileRO::\
uncompressEntry(void*, int) const+12)
Space for the file is now allocated using fallocate rather than
ftruncate, since ftruncate dont actually reserve space on disk. When writes
to the mmaped pointer fails to be realized due to out of space SIGBUS
is the result. With this change we make sure that there is space available
before mmaping the pointer.
Change-Id: Ic5e8c33dbe729edb57919dacff73811b34cc2dc2
Diffstat (limited to 'base/errors_unix.cpp')
0 files changed, 0 insertions, 0 deletions