diff options
| author | Chih-Hung Hsieh <chh@google.com> | 2016-07-27 16:25:51 -0700 |
|---|---|---|
| committer | Chih-Hung Hsieh <chh@google.com> | 2016-08-01 11:55:42 -0700 |
| commit | 8f7b9e3d39cdae8363816aa7bcbab0d79fd70cea (patch) | |
| tree | 136c54668ea9515735fc14d1e71eb514c62f5a57 /adb/adb_utils_test.cpp | |
| parent | eafeb75c492677550a62dfe19623fac8b7be0344 (diff) | |
Fix clang-tidy performance warnings in syste/core.
* Use const reference type for parameters to avoid unnecessary copy.
* Suppress warning of not using faster overloaded string find function.
Bug: 30407689
Bug: 30411878
Change-Id: I6cfdbbd50cf5e8f3db6e5263076d3a17a9a791ee
Test: build with WITH_TIDY=1
Merged-In: Ie79dbe21899867bc62031f8618bb1322b8071525
Diffstat (limited to 'adb/adb_utils_test.cpp')
| -rw-r--r-- | adb/adb_utils_test.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/adb/adb_utils_test.cpp b/adb/adb_utils_test.cpp index aabc5d7338..9daa397d0c 100644 --- a/adb/adb_utils_test.cpp +++ b/adb/adb_utils_test.cpp @@ -111,7 +111,7 @@ TEST(adb_utils, adb_dirname) { EXPECT_EQ("/system/bin", adb_dirname("/system/bin/sh/")); } -void test_mkdirs(const std::string basepath) { +void test_mkdirs(const std::string& basepath) { // Test creating a directory hierarchy. EXPECT_TRUE(mkdirs(basepath)); // Test finding an existing directory hierarchy. |