Fix more buffer overruns.

Also add some tests.

Bug: 20323050
Change-Id: I9eaf3dc04efd85206663c4cca4f8c1208620a89a

1 files changed, 52 insertions, 0 deletions

diff --git a/adb/adb_utils_test.cpp b/adb/adb_utils_test.cpp
new file mode 100644
index 0000000000..95e28a85f8
--- /dev/null
+++ b/adb/adb_utils_test.cpp
@@ -0,0 +1,52 @@
+/*
+ * Copyright (C) 2015 The Android Open Source Project
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "adb_utils.h"
+
+#include <gtest/gtest.h>
+
+TEST(adb_utils, directory_exists) {
+  ASSERT_TRUE(directory_exists("/proc"));
+  ASSERT_FALSE(directory_exists("/proc/self")); // Symbolic link.
+  ASSERT_FALSE(directory_exists("/proc/does-not-exist"));
+}
+
+TEST(adb_utils, escape_arg) {
+  ASSERT_EQ(R"("")", escape_arg(""));
+
+  ASSERT_EQ(R"(abc)", escape_arg("abc"));
+
+  ASSERT_EQ(R"(\ abc)", escape_arg(" abc"));
+  ASSERT_EQ(R"(\'abc)", escape_arg("'abc"));
+  ASSERT_EQ(R"(\"abc)", escape_arg("\"abc"));
+  ASSERT_EQ(R"(\\abc)", escape_arg("\\abc"));
+  ASSERT_EQ(R"(\(abc)", escape_arg("(abc"));
+  ASSERT_EQ(R"(\)abc)", escape_arg(")abc"));
+
+  ASSERT_EQ(R"(abc\ abc)", escape_arg("abc abc"));
+  ASSERT_EQ(R"(abc\'abc)", escape_arg("abc'abc"));
+  ASSERT_EQ(R"(abc\"abc)", escape_arg("abc\"abc"));
+  ASSERT_EQ(R"(abc\\abc)", escape_arg("abc\\abc"));
+  ASSERT_EQ(R"(abc\(abc)", escape_arg("abc(abc"));
+  ASSERT_EQ(R"(abc\)abc)", escape_arg("abc)abc"));
+
+  ASSERT_EQ(R"(abc\ )", escape_arg("abc "));
+  ASSERT_EQ(R"(abc\')", escape_arg("abc'"));
+  ASSERT_EQ(R"(abc\")", escape_arg("abc\""));
+  ASSERT_EQ(R"(abc\\)", escape_arg("abc\\"));
+  ASSERT_EQ(R"(abc\()", escape_arg("abc("));
+  ASSERT_EQ(R"(abc\))", escape_arg("abc)"));
+}