diff options
author | Christopher Ferris <cferris@google.com> | 2020-08-29 01:02:25 +0000 |
---|---|---|
committer | Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com> | 2020-08-29 01:02:25 +0000 |
commit | 76d617c81cc07b7cb1564ffbc7cb3c3cb0894622 (patch) | |
tree | e092fd3a2ed15a05de6d70917250686115ee7720 | |
parent | e0e6fc8722336ea6702000afe178699184fcfd78 (diff) | |
parent | ebd6a0f3094e4c56336e2e4e1b1afd9027247671 (diff) |
Merge "libunwindstack: expose static version of BuildFrameFromPcOnly." am: f60d4f9a04 am: ebd6a0f309
Original change: https://android-review.googlesource.com/c/platform/system/core/+/1406430
Change-Id: Ie6fb977c9c79ae5c6343473f97b4b4f59bdb2f83
-rw-r--r-- | libunwindstack/Unwinder.cpp | 22 | ||||
-rw-r--r-- | libunwindstack/include/unwindstack/Unwinder.h | 2 |
2 files changed, 16 insertions, 8 deletions
diff --git a/libunwindstack/Unwinder.cpp b/libunwindstack/Unwinder.cpp index e0edc597b..57806c157 100644 --- a/libunwindstack/Unwinder.cpp +++ b/libunwindstack/Unwinder.cpp @@ -397,19 +397,20 @@ bool UnwinderFromPid::Init(ArchEnum arch) { return true; } -FrameData Unwinder::BuildFrameFromPcOnly(uint64_t pc) { +FrameData Unwinder::BuildFrameFromPcOnly(uint64_t pc, ArchEnum arch, Maps* maps, + JitDebug* jit_debug, + std::shared_ptr<Memory> process_memory, + bool resolve_names) { FrameData frame; - Maps* maps = GetMaps(); MapInfo* map_info = maps->Find(pc); - if (map_info == nullptr || regs_ == nullptr) { + if (map_info == nullptr || arch == ARCH_UNKNOWN) { frame.pc = pc; frame.rel_pc = pc; return frame; } - ArchEnum arch = regs_->Arch(); - Elf* elf = map_info->GetElf(GetProcessMemory(), arch); + Elf* elf = map_info->GetElf(process_memory, arch); uint64_t relative_pc = elf->GetRelPc(pc, map_info); @@ -419,9 +420,9 @@ FrameData Unwinder::BuildFrameFromPcOnly(uint64_t pc) { uint64_t debug_pc = relative_pc; // If we don't have a valid ELF file, check the JIT. - if (!elf->valid() && jit_debug_ != nullptr) { + if (!elf->valid() && jit_debug != nullptr) { uint64_t jit_pc = pc - pc_adjustment; - Elf* jit_elf = jit_debug_->GetElf(maps, jit_pc); + Elf* jit_elf = jit_debug->GetElf(maps, jit_pc); if (jit_elf != nullptr) { debug_pc = jit_pc; elf = jit_elf; @@ -439,7 +440,7 @@ FrameData Unwinder::BuildFrameFromPcOnly(uint64_t pc) { frame.map_flags = map_info->flags; frame.map_load_bias = elf->GetLoadBias(); - if (!resolve_names_ || + if (!resolve_names || !elf->GetFunctionName(debug_pc, &frame.function_name, &frame.function_offset)) { frame.function_name = ""; frame.function_offset = 0; @@ -447,4 +448,9 @@ FrameData Unwinder::BuildFrameFromPcOnly(uint64_t pc) { return frame; } +FrameData Unwinder::BuildFrameFromPcOnly(uint64_t pc) { + return BuildFrameFromPcOnly(pc, regs_ ? regs_->Arch() : ARCH_UNKNOWN, maps_, jit_debug_, + process_memory_, resolve_names_); +} + } // namespace unwindstack diff --git a/libunwindstack/include/unwindstack/Unwinder.h b/libunwindstack/include/unwindstack/Unwinder.h index a974b6349..3df8aadfd 100644 --- a/libunwindstack/include/unwindstack/Unwinder.h +++ b/libunwindstack/include/unwindstack/Unwinder.h @@ -120,6 +120,8 @@ class Unwinder { // frames collected by frame-pointer unwinding that's done outside of // libunwindstack. This is used by tombstoned to symbolize frame pointer-based // stack traces that are collected by tools such as GWP-ASan and MTE. + static FrameData BuildFrameFromPcOnly(uint64_t pc, ArchEnum arch, Maps* maps, JitDebug* jit_debug, + std::shared_ptr<Memory> process_memory, bool resolve_names); FrameData BuildFrameFromPcOnly(uint64_t pc); protected: |