Notify IpClient DHCP process success when entering DHCP Bound State.

After introducing IP address conflict detection mechanism, we might get
an duplicated IP address though the DHCP handshake, it's not appropriate
to notify IpClient that DHCP success and configure interface with this IP
address immediately. However, Bound State ensures that we have already
done DAD (if enabled) and IP address has been configured on the interface.
More reasonable to notify IpClient DHCP success when entering Bound state.

This CL does not change the behaviour of a successful transaction.
The call graph is:

- notifySuccess
  - acceptDhcpResults
    - when receiving an ACK in DhcpReacquiringState
      - next action: transition to DhcpBoundState
    - called from confirmDhcpLease
      - when receiving a rapid commit ACK in DhcpInitState
        - next action: ConfiguringInterfaceState
          - next action: configure link address, then transition to DhcpBoundState
      - when receiving an ACK in DhcpRequestingState
        - next action: ConfiguringInterfaceState
          - next action: configure link address, then transition to DhcpBoundState

This CL does change the behaviour of failed transactions. For example,
if configuring the IP address or opening the UDP socket fails, after
this CL, the client will no longer notify success. This is more correct.

Bug: 130775067
Test: atest NetworkStackTests NetworkStackIntegrationTests
Change-Id: Ie3b5edd8ddf04aac258b97ecaa291fcb25611bbd

1 files changed, 1 insertions, 1 deletions

diff --git a/src/android/net/dhcp/DhcpClient.java b/src/android/net/dhcp/DhcpClient.java
index 889bfce..9e24ca8 100644
--- a/src/android/net/dhcp/DhcpClient.java
+++ b/src/android/net/dhcp/DhcpClient.java
@@ -638,7 +638,6 @@ public class DhcpClient extends StateMachine {
         }
         mOffer = null;
         Log.d(TAG, msg + " lease: " + mDhcpLease);
-        notifySuccess();
     }
 
     private void clearDhcpState() {
@@ -1150,6 +1149,7 @@ public class DhcpClient extends StateMachine {
                 transitionTo(mStoppedState);
             }
 
+            notifySuccess();
             scheduleLeaseTimers();
             logTimeToBoundState();
         }