summaryrefslogtreecommitdiff
path: root/src/com/android
diff options
context:
space:
mode:
authorFrank Li <lifr@google.com>2020-05-28 04:03:28 +0000
committerAutomerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>2020-05-28 04:03:28 +0000
commitbd1eb4e698c942c567ff29f3e3c0f46c216c768c (patch)
treeaa813e6a57292870eebe2e3619fcd8e968249a9b /src/com/android
parent251bbe024d8ba8991a93b116301ce8c0c1cacb41 (diff)
parent59b66b8f2c3ab4ad3d9ecf372e12a498f0a45f5a (diff)
Merge "Change stopwatch accuracy from milliseconds to microseconds" into rvc-dev am: 59b66b8f2c
Change-Id: I07c4df23a6f8b932ce295846f91a9fc89385ce5b
Diffstat (limited to 'src/com/android')
-rw-r--r--src/com/android/networkstack/util/DnsUtils.java11
-rwxr-xr-xsrc/com/android/server/connectivity/NetworkMonitor.java10
2 files changed, 11 insertions, 10 deletions
diff --git a/src/com/android/networkstack/util/DnsUtils.java b/src/com/android/networkstack/util/DnsUtils.java
index c47ccc1..83f2daf 100644
--- a/src/com/android/networkstack/util/DnsUtils.java
+++ b/src/com/android/networkstack/util/DnsUtils.java
@@ -147,7 +147,7 @@ public class DnsUtils {
} catch (TimeoutException | InterruptedException e) {
errorMsg = "Timeout";
} finally {
- logDnsResult(result, watch.stop() /* latency */, logger, type, errorMsg);
+ logDnsResult(result, watch.stop() / 1000 /* latencyMs */, logger, type, errorMsg);
}
if (null != errorMsg) throw new UnknownHostException(host);
@@ -155,8 +155,9 @@ public class DnsUtils {
return result.toArray(new InetAddress[0]);
}
- private static void logDnsResult(@Nullable final List<InetAddress> results, final long latency,
- @Nullable final DnsLogFunc logger, int type, @NonNull final String errorMsg) {
+ private static void logDnsResult(@Nullable final List<InetAddress> results,
+ final long latencyMs, @Nullable final DnsLogFunc logger, int type,
+ @NonNull final String errorMsg) {
if (logger == null) {
return;
}
@@ -166,9 +167,9 @@ public class DnsUtils {
for (InetAddress address : results) {
builder.append(',').append(address.getHostAddress());
}
- logger.log(String.format("%dms OK %s", latency, builder.substring(1)));
+ logger.log(String.format("%dms OK %s", latencyMs, builder.substring(1)));
} else {
- logger.log(String.format("%dms FAIL in type %s %s", latency, dnsTypeToStr(type),
+ logger.log(String.format("%dms FAIL in type %s %s", latencyMs, dnsTypeToStr(type),
errorMsg));
}
}
diff --git a/src/com/android/server/connectivity/NetworkMonitor.java b/src/com/android/server/connectivity/NetworkMonitor.java
index 093118a..8a1b0c7 100755
--- a/src/com/android/server/connectivity/NetworkMonitor.java
+++ b/src/com/android/server/connectivity/NetworkMonitor.java
@@ -1412,11 +1412,11 @@ public class NetworkMonitor extends StateMachine {
time = watch.stop();
final String strIps = Arrays.toString(ips);
success = (ips != null && ips.length > 0);
- validationLog(PROBE_PRIVDNS, host, String.format("%dms: %s", time, strIps));
+ validationLog(PROBE_PRIVDNS, host, String.format("%dus: %s", time, strIps));
} catch (UnknownHostException uhe) {
time = watch.stop();
validationLog(PROBE_PRIVDNS, host,
- String.format("%dms - Error: %s", time, uhe.getMessage()));
+ String.format("%dus - Error: %s", time, uhe.getMessage()));
}
logValidationProbe(time, PROBE_PRIVDNS, success ? DNS_SUCCESS : DNS_FAILURE);
return success;
@@ -2943,18 +2943,18 @@ public class NetworkMonitor extends StateMachine {
if (mEvaluationTimer.isRunning()) {
int[] transports = mNetworkCapabilities.getTransportTypes();
mMetricsLog.log(mCleartextDnsNetwork, transports,
- new NetworkEvent(evtype, mEvaluationTimer.stop()));
+ new NetworkEvent(evtype, mEvaluationTimer.stop() / 1000));
mEvaluationTimer.reset();
}
}
- private void logValidationProbe(long durationMs, int probeType, int probeResult) {
+ private void logValidationProbe(long durationUs, int probeType, int probeResult) {
int[] transports = mNetworkCapabilities.getTransportTypes();
boolean isFirstValidation = validationStage().mIsFirstValidation;
ValidationProbeEvent ev = new ValidationProbeEvent.Builder()
.setProbeType(probeType, isFirstValidation)
.setReturnCode(probeResult)
- .setDurationMs(durationMs)
+ .setDurationMs(durationUs / 1000)
.build();
mMetricsLog.log(mCleartextDnsNetwork, transports, ev);
}